Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(reconcile): adding optional condition when ignoring json #20010

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

rumstead
Copy link
Member

@rumstead rumstead commented Sep 19, 2024

If an application has no conditions, eg failures or shared warning messages the conditions array won't be populated. The json patch will cause (debug) logs to be produced.
time="2024-09-19T14:43:44Z" level=debug msg="Failed to apply normalization: JQ patch returned error: cannot iterate over: null"

❯ k get applications.argoproj.io kust-app2 -o json | jq '.status?.conditions[]?.lastTransitionTime'
"2024-09-18T12:21:11Z"
~                                                                                                                                                                                                                                                                        
❯ k get applications.argoproj.io kust-app -o json | jq '.status?.conditions[]?.lastTransitionTime'
~                                                                                                                                                                                                                                                                        
❯ k get applications.argoproj.io kust-app -o json | jq '.status.conditions[].lastTransitionTime'
jq: error (at <stdin>:161): Cannot iterate over null (null)

While the logline only happens in debug mode, it floods the logs when you have many applications that are "healthy" without conditions. It spams the logs and makes it hard to see what actual debug logs you are after. :)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead rumstead requested review from a team as code owners September 19, 2024 15:29
Copy link

bunnyshell bot commented Sep 19, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Queued actions:

# Action Triggered By
1 ❌ Delete pull request closed

Copy link

bunnyshell bot commented Sep 19, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@ishitasequeira ishitasequeira merged commit 735d090 into argoproj:master Sep 19, 2024
22 of 24 checks passed
@rumstead rumstead deleted the docs/reconcile-ignore branch September 19, 2024 15:47
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
…oj#20010)

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants