Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix broken link #20070

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix: fix broken link #20070

merged 2 commits into from
Sep 24, 2024

Conversation

nitishfy
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@nitishfy
fix broken link
d004cbd 
Signed-off-by: nitishfy <justnitish06@gmail.com>
@nitishfy nitishfy requested review from a team as code owners September 24, 2024 06:23
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 24, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 24, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

gdsoumya
gdsoumya requested changes Sep 24, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@nitishfy
fix broken link
0963b19 
Signed-off-by: nitishfy <justnitish06@gmail.com>
@blakepettersson blakepettersson merged commit dbc94ba into argoproj:master Sep 24, 2024
22 checks passed
@nitishfy nitishfy deleted the broken-link branch September 24, 2024 10:55
cveld pushed a commit to cveld/argo-cd that referenced this pull request Sep 24, 2024
@nitishfy @cveld
fix: fix broken link (argoproj#20070)
0969537 
* fix broken link

Signed-off-by: nitishfy <justnitish06@gmail.com>

* fix broken link

Signed-off-by: nitishfy <justnitish06@gmail.com>

---------

Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Carl in 't Veld <carl@intveld.nl>
ratulbasak pushed a commit to ratulbasak/argo-cd that referenced this pull request Sep 25, 2024
@nitishfy @ratulbasak
fix: fix broken link (argoproj#20070)
c6a5bac 
* fix broken link

Signed-off-by: nitishfy <justnitish06@gmail.com>

* fix broken link

Signed-off-by: nitishfy <justnitish06@gmail.com>

---------

Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@nitishfy nitishfy mentioned this pull request Oct 25, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdsoumya gdsoumya gdsoumya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitishfy @gdsoumya @blakepettersson