-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pkce): 18045 PKCE respect base href and Reauth to PKCE on token expire #20110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
austin5219
force-pushed
the
pkce-basepath-fix
branch
2 times, most recently
from
September 25, 2024 22:03
d582ec5
to
ade4b32
Compare
austin5219
changed the title
fix(pkce): PKCE respect base href and Reauth to PKCE on token expire
fix PKCE respect base href and Reauth to PKCE on token expire
Sep 25, 2024
austin5219
changed the title
fix PKCE respect base href and Reauth to PKCE on token expire
fix: PKCE respect base href and Reauth to PKCE on token expire
Sep 25, 2024
austin5219
changed the title
fix: PKCE respect base href and Reauth to PKCE on token expire
fix: PKCE respect base href and Reauth to PKCE on token expire for issue 18045
Sep 25, 2024
austin5219
changed the title
fix: PKCE respect base href and Reauth to PKCE on token expire for issue 18045
fix: 18045 PKCE respect base href and Reauth to PKCE on token expire
Sep 25, 2024
austin5219
changed the title
fix: 18045 PKCE respect base href and Reauth to PKCE on token expire
fix(pkce): 18045 PKCE respect base href and Reauth to PKCE on token expire
Sep 26, 2024
14 tasks
@crenshaw-dev could I get a re-review with the evidence attached above? |
reggie-k
reviewed
Oct 9, 2024
reggie-k
reviewed
Oct 13, 2024
7 tasks
austin5219
force-pushed
the
pkce-basepath-fix
branch
from
October 16, 2024 03:02
b0e42a9
to
90068ad
Compare
austin5219
force-pushed
the
pkce-basepath-fix
branch
from
October 16, 2024 03:22
90068ad
to
20df015
Compare
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
austin5219
force-pushed
the
pkce-basepath-fix
branch
from
October 16, 2024 03:52
20df015
to
765f05b
Compare
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
…xt for error handling within 401 error Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Closed by #20202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18045
This prepends the server base href to the PKCE login auth flow and paths rather than hardcoding pkce paths off of '/'
This also fixes on token expiry and re-auth that the user is redirected to PKCE if configured rather than always sending the user to the dex login path.
This fix should be cherry-picked to 2.12
Checklist: