-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cherrypick semver fix #20096 into 2.12 #20215
fix: cherrypick semver fix #20096 into 2.12 #20215
Conversation
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
2d08bc9
to
d8e3c0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issue otherwise LGTM
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix linter issues
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.12 #20215 +/- ##
=============================================
Coverage 50.35% 50.35%
=============================================
Files 313 313
Lines 43155 43155
=============================================
+ Hits 21729 21731 +2
- Misses 18939 18942 +3
+ Partials 2487 2482 -5 ☔ View full report in Codecov by Sentry. |
Not sure what the failing generated code check is about here; I don't think I've changed anything related to codegen. Let me know if there's anything in particular to run! |
@PaulSonOfLars that is expected in the |
e2eb54c
into
argoproj:release-2.12
Checklist: