Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherrypick semver fix #20096 into 2.12 #20215

Merged

Conversation

PaulSonOfLars
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
@PaulSonOfLars PaulSonOfLars requested review from a team as code owners October 3, 2024 17:17
@PaulSonOfLars PaulSonOfLars changed the title cherrypick semver fix #20096 into 2.12 fix: cherrypick semver fix #20096 into 2.12 Oct 3, 2024
@PaulSonOfLars PaulSonOfLars force-pushed the paul/fix-semver-into-2.12 branch from 2d08bc9 to d8e3c0e Compare October 3, 2024 17:18
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue otherwise LGTM

Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving LGTM

Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix linter issues

Signed-off-by: Paul Larsen <pnvlarsen@gmail.com>
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.35%. Comparing base (a05b042) to head (c76bf56).
Report is 2 commits behind head on release-2.12.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-2.12   #20215   +/-   ##
=============================================
  Coverage         50.35%   50.35%           
=============================================
  Files               313      313           
  Lines             43155    43155           
=============================================
+ Hits              21729    21731    +2     
- Misses            18939    18942    +3     
+ Partials           2487     2482    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulSonOfLars
Copy link
Contributor Author

Not sure what the failing generated code check is about here; I don't think I've changed anything related to codegen. Let me know if there's anything in particular to run!

@blakepettersson
Copy link
Member

@PaulSonOfLars that is expected in the release-* branches, so you should be good to go. @pasha-codefresh does this look good to you?

@pasha-codefresh pasha-codefresh merged commit e2eb54c into argoproj:release-2.12 Oct 10, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants