chore: Added unit tests and fix e2e tests for application sync decoupling feature (cherry-pick #19966) #20219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
…ling feature (#19966) * fixed doc comments and added unit tests Signed-off-by: anandf <anjoseph@redhat.com> * Added comments for the newly added unit tests Signed-off-by: anandf <anjoseph@redhat.com> * Refactored method name to deriveServiceAccountToImpersonate Signed-off-by: anandf <anjoseph@redhat.com> * Using const name in return value Signed-off-by: anandf <anjoseph@redhat.com> * Added unit tests for argocd proj add-destination-service-accounts Signed-off-by: anandf <anjoseph@redhat.com> * Fixed failing e2e tests Signed-off-by: anandf <anjoseph@redhat.com> * Fix linting errors Signed-off-by: anandf <anjoseph@redhat.com> * Using require package instead of assert and fixed code generation Signed-off-by: anandf <anjoseph@redhat.com> * Removed parallel execution of tests for sync with impersonate Signed-off-by: anandf <anjoseph@redhat.com> * Added err checks for glob validations Signed-off-by: anandf <anjoseph@redhat.com> * Fixed e2e tests for sync impersonation Signed-off-by: anandf <anjoseph@redhat.com> * Using consistently based expects in E2E tests Signed-off-by: anandf <anjoseph@redhat.com> * Added more unit tests and fixed go generate Signed-off-by: anandf <anjoseph@redhat.com> * Fixed failed lint errors, unit and e2e test failures Signed-off-by: anandf <anjoseph@redhat.com> * Fixed goimports linter issue Signed-off-by: anandf <anjoseph@redhat.com> * Added code comments and added few missing unit tests Signed-off-by: anandf <anjoseph@redhat.com> * Added missing unit test for GetDestinationServiceAccounts method Signed-off-by: anandf <anjoseph@redhat.com> * Fixed goimports formatting with local for project_test.go Signed-off-by: anandf <anjoseph@redhat.com> * Corrected typo in a field name additionalObjs Signed-off-by: anandf <anjoseph@redhat.com> * Fixed failing unit tests Signed-off-by: anandf <anjoseph@redhat.com> --------- Signed-off-by: anandf <anjoseph@redhat.com>
ishitasequeira
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked chore: Added unit tests and fix e2e tests for application sync decoupling feature (#19966)
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com