-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the unmatching template issue introduced from #20237 #20410
fix: the unmatching template issue introduced from #20237 #20410
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
6cf0c80
to
4cdf072
Compare
The error in the notification controller shows unmatching "{{end}}" ``` error in 'app-health-degraded' teams.potentialAction: template: app-health-degraded:14: unexpected {{end}}" ``` Signed-off-by: Pan Luo <pan.luo@ubc.ca>
4cdf072
to
3102f0e
Compare
Signed-off-by: Pan Luo <pan.luo@ubc.ca>
d6c5964
to
23e2360
Compare
Signed-off-by: Pan Luo <pan.luo@ubc.ca>
206797f
to
a25bdb4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20410 +/- ##
==========================================
+ Coverage 56.02% 56.05% +0.02%
==========================================
Files 322 322
Lines 44802 44802
==========================================
+ Hits 25099 25112 +13
+ Misses 17104 17086 -18
- Partials 2599 2604 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
…goproj#20410) * Fix the unmatching template error The error in the notification controller shows unmatching "{{end}}" ``` error in 'app-health-degraded' teams.potentialAction: template: app-health-degraded:14: unexpected {{end}}" ``` Signed-off-by: Pan Luo <pan.luo@ubc.ca> * update templates to match the install.yaml Signed-off-by: Pan Luo <pan.luo@ubc.ca> * fix inconsistent yaml block style formating Signed-off-by: Pan Luo <pan.luo@ubc.ca> --------- Signed-off-by: Pan Luo <pan.luo@ubc.ca>
…goproj#20410) * Fix the unmatching template error The error in the notification controller shows unmatching "{{end}}" ``` error in 'app-health-degraded' teams.potentialAction: template: app-health-degraded:14: unexpected {{end}}" ``` Signed-off-by: Pan Luo <pan.luo@ubc.ca> * update templates to match the install.yaml Signed-off-by: Pan Luo <pan.luo@ubc.ca> * fix inconsistent yaml block style formating Signed-off-by: Pan Luo <pan.luo@ubc.ca> --------- Signed-off-by: Pan Luo <pan.luo@ubc.ca> Signed-off-by: Adrian Aneci <aneci@adobe.com>
The error in the notification controller shows unmatching "{{end}}"
This PR is to correct the above issue and make the notification controller happy again!
Since #20237 has not been included in any release yet. No cherry-pick is needed.
Checklist: