Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): source can in fact be undefined (#20381) (backport for 2.12) #20420

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix(ui): source can in fact be undefined (#20381) (backport for 2.12) #20420

merged 1 commit into from
Oct 17, 2024

Conversation

blakepettersson
Copy link
Member

  • fix(ui): source can in fact be undefined

The assumption that a source is always there is not always true. To repro, create an app-of-apps containing a single app without any source present. In the UI this will crash, horribly. This PR fixes that so that instead of crashing the user will get useful info indicating what is wrong with the app.

  • chore(ui): some cr tweaks

  • chore(ui): some cr tweaks

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@blakepettersson
fix(ui): source can in fact be undefined (argoproj#20381)
a158b6f 
* fix(ui): source can in fact be `undefined`

The assumption that a source is always there is not always true. To
repro, create an app-of-apps containing a single app without any `source`
present. In the UI this will crash, horribly. This PR fixes that so
that instead of crashing the user will get useful info indicating what
is wrong with the app.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* chore(ui): some cr tweaks

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

* chore(ui): some cr tweaks

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>

---------

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@blakepettersson blakepettersson requested a review from a team as a code owner October 17, 2024 08:28
nitishfy
nitishfy reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you paste the After view for this?

@blakepettersson blakepettersson changed the title fix(ui): source can in fact be undefined (#20381) fix(ui): source can in fact be undefined (#20381) (backport for 2.12) Oct 17, 2024
@blakepettersson
Copy link
Member Author

Hey Nitish, see the linked PR #20381 - this is a backport for 2.12

@ishitasequeira ishitasequeira merged commit 6e6857e into argoproj:release-2.12 Oct 17, 2024
19 checks passed
@blakepettersson blakepettersson deleted the cherry-pick-82e9b5-release-2.12 branch October 17, 2024 12:13
@nitishfy nitishfy mentioned this pull request Oct 25, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitishfy nitishfy nitishfy left review comments

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blakepettersson @ishitasequeira @nitishfy