Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect pluralization on resources - #20210 #20468

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix: Incorrect pluralization on resources - #20210 #20468

merged 2 commits into from
Oct 23, 2024

Conversation

yashrtalele
Copy link
Contributor

@yashrtalele yashrtalele commented Oct 20, 2024 •
edited
Loading

Extra s was being added to the resources. So, I am checking if the resource is ending in 's' or not. If it is ending in 's' no change, but if not then 's' is added at the end of the word.
Fixes [#20210]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@yashrtalele yashrtalele requested a review from a team as a code owner October 20, 2024 07:12
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 20, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@yashrtalele yashrtalele changed the title Fixed incorrect pluralization on resources Fix incorrect pluralization on resources Oct 20, 2024
@yashrtalele yashrtalele changed the title Fix incorrect pluralization on resources fix incorrect pluralization on resources Oct 20, 2024
@yashrtalele yashrtalele changed the title fix incorrect pluralization on resources fix: Incorrect pluralization on resources #20210 Oct 20, 2024
@yashrtalele yashrtalele changed the title fix: Incorrect pluralization on resources #20210 fix: Incorrect pluralization on resources Oct 20, 2024
@yashrtalele
Fixed incorrect pluralization on resources
e1dac4b 
Extra s was being added to the resources. So, I am checking if the
resource is ending in 's' or not. If it is ending in 's' no change, but
if not then 's' is added at the end of the word.

Signed-off-by: Yash Talele <yashrtalele@gmail.com>
@yashrtalele yashrtalele force-pushed the fix-incorrect-pluralization-on-resources branch from ac1547e to e1dac4b Compare October 20, 2024 07:27
@yashrtalele yashrtalele changed the title fix: Incorrect pluralization on resources fix: Incorrect pluralization on resources (#20210) Oct 20, 2024
@yashrtalele yashrtalele changed the title fix: Incorrect pluralization on resources (#20210) fix: Incorrect pluralization on resources - #20210 Oct 20, 2024
nitishfy
nitishfy approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you share an after image picture too?

@yashrtalele
Copy link
Contributor Author

LGTM. Can you share an after image picture too?

Before
Screenshot 2024-10-20 at 12 21 26 PM

After
Screenshot 2024-10-20 at 12 21 33 PM

todaywasawesome
todaywasawesome approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made me chuckle.

image

@todaywasawesome todaywasawesome enabled auto-merge (squash) October 23, 2024 14:37
@todaywasawesome todaywasawesome merged commit 5b25b28 into argoproj:master Oct 23, 2024
22 checks passed
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@yashrtalele @todaywasawesome @adriananeci
Fixed incorrect pluralization on resources (argoproj#20468)
7a68af1 
Extra s was being added to the resources. So, I am checking if the
resource is ending in 's' or not. If it is ending in 's' no change, but
if not then 's' is added at the end of the word.

Signed-off-by: Yash Talele <yashrtalele@gmail.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitishfy nitishfy nitishfy approved these changes

@gdsoumya gdsoumya gdsoumya approved these changes

@otherguy otherguy otherguy approved these changes

@todaywasawesome todaywasawesome todaywasawesome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yashrtalele @todaywasawesome @otherguy @gdsoumya @nitishfy