Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): fix the slider close transition #20641

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix(ui): fix the slider close transition #20641

merged 1 commit into from
Nov 1, 2024

Conversation

ashutosh16
Copy link
Contributor

Screen.Recording.2024-11-01.at.12.57.09.mov

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@ashutosh16 ashutosh16 requested a review from leoluz November 1, 2024 19:58
@ashutosh16 ashutosh16 requested a review from a team as a code owner November 1, 2024 19:58
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Nov 1, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@leoluz leoluz self-assigned this Nov 1, 2024
leoluz
leoluz reviewed Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit d761c94 into argoproj:master Nov 1, 2024
23 checks passed
@leoluz
Copy link
Collaborator

leoluz commented Nov 1, 2024

/cherry-pick release-2.13

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 1, 2024
@ashutosh16
fix(ui): fix the slider tansition (#20641)
847ed53
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Nov 1, 2024
Merged
leoluz pushed a commit that referenced this pull request Nov 1, 2024
@gcp-cherry-pick-bot @ashutosh16
fix(ui): fix the slider tansition (#20641) (#20642)
1fcbe3f 
Co-authored-by: Ashu <11219262+ashutosh16@users.noreply.github.com>
@ashutosh16 ashutosh16 deleted the flicker-slider branch November 1, 2024 22:28
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@ashutosh16 @adriananeci
fix(ui): fix the slider tansition (argoproj#20641)
0294084 
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees

@leoluz leoluz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashutosh16 @leoluz