feat: adopt delete app confirmation to new prompt util #20664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pashakostohrys <pavel@codefresh.io>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20664 +/- ##
=========================================
Coverage ? 55.10%
=========================================
Files ? 324
Lines ? 55262
Branches ? 0
=========================================
Hits ? 30451
Misses ? 22196
Partials ? 2615 ☔ View full report in Codecov by Sentry. |
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
cmd/argocd/commands/app.go
Outdated
Comment on lines
1456
to
1459
| var ( | ||
| confirmAll = false | ||
| confirm bool = false | ||
| ) |
There was a problem hiding this comment.
nit: should we add data type to both variables to be consistent?
Signed-off-by: pashakostohrys <pavel@codefresh.io>
ishitasequeira
approved these changes
Nov 5, 2024
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
* feat: adopt delete app confirmation to new prompt util Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: adopt delete app confirmation to new prompt util Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: adopt delete app confirmation to new prompt util Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: adopt delete app confirmation to new prompt util Signed-off-by: pashakostohrys <pavel@codefresh.io> * chore: remove type where it is not needed Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #19528
Here also was a bug related to deletion of multiple resources, it didnt because numOfApps was initialized incorrectly