Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error logs in server/cluster/cluser.go #20711

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

SuminSSon
Copy link
Contributor

fixes part of #20710

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: SuminSSon <itoodo12@gmail.com>
@SuminSSon SuminSSon requested a review from a team as a code owner November 8, 2024 05:05
Copy link

bunnyshell bot commented Nov 8, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: SuminSSon <itoodo12@gmail.com>
Copy link
Contributor

@andrii-korotkov-verkada andrii-korotkov-verkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the PR name imporve -> improve

@SuminSSon SuminSSon changed the title chore: imporve error logs in server/cluster/cluser.go chore: improve error logs in server/cluster/cluser.go Nov 8, 2024
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!! Rebased the PR to rerun the unit tests. Will wait for CI to pass for approving and merging the change.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuminSSon can you take a look at the failing tests?

@SuminSSon
Copy link
Contributor Author

@ishitasequeira Thank you! I’ll check the failing tests and make any necessary adjustments. I’ll work on getting the CI to pass.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 26.47059% with 25 lines in your changes missing coverage. Please review.

Project coverage is 55.12%. Comparing base (993d79c) to head (27dbfed).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/cluster/cluster.go 26.47% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20711      +/-   ##
==========================================
- Coverage   55.21%   55.12%   -0.09%     
==========================================
  Files         324      324              
  Lines       55256    55256              
==========================================
- Hits        30508    30459      -49     
- Misses      22133    22174      +41     
- Partials     2615     2623       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuminSSon
Copy link
Contributor Author

@ishitasequeira I’ve fixed the failing tests, and everything is passing now. Please let me know if there’s anything else I should address. Thank you!

@ishitasequeira ishitasequeira merged commit 0f872f5 into argoproj:master Nov 13, 2024
27 checks passed
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants