-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve error logs in server/cluster/cluser.go #20711
Conversation
Signed-off-by: SuminSSon <itoodo12@gmail.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: SuminSSon <itoodo12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in the PR name imporve -> improve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me!! Rebased the PR to rerun the unit tests. Will wait for CI to pass for approving and merging the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuminSSon can you take a look at the failing tests?
@ishitasequeira Thank you! I’ll check the failing tests and make any necessary adjustments. I’ll work on getting the CI to pass. |
Signed-off-by: SuminSSon <itoodo12@gmail.com>
Signed-off-by: SuminSSon <itoodo12@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20711 +/- ##
==========================================
- Coverage 55.21% 55.12% -0.09%
==========================================
Files 324 324
Lines 55256 55256
==========================================
- Hits 30508 30459 -49
- Misses 22133 22174 +41
- Partials 2615 2623 +8 ☔ View full report in Codecov by Sentry. |
@ishitasequeira I’ve fixed the failing tests, and everything is passing now. Please let me know if there’s anything else I should address. Thank you! |
Signed-off-by: Adrian Aneci <aneci@adobe.com>
fixes part of #20710
Checklist: