Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable automaxprocs logging (#20069) - cherry-pick 2.13 #20718

Conversation

pasha-codefresh
Copy link
Member

@pasha-codefresh pasha-codefresh commented Nov 8, 2024

related to #20069
#20527

Closes: #20690

* disable automaxprocs logging

Signed-off-by: nitishfy <justnitish06@gmail.com>

fix lint checks

Signed-off-by: nitishfy <justnitish06@gmail.com>

move maxprocs to main.go

Signed-off-by: nitishfy <justnitish06@gmail.com>

move set auto max procs to a function

Signed-off-by: nitishfy <justnitish06@gmail.com>

add info log

Signed-off-by: nitishfy <justnitish06@gmail.com>

* add info log

Signed-off-by: nitishfy <justnitish06@gmail.com>

* fix lint checks

Signed-off-by: nitishfy <justnitish06@gmail.com>

* fix lint checks

Signed-off-by: nitishfy <justnitish06@gmail.com>

* add unit test

Signed-off-by: nitishfy <justnitish06@gmail.com>

* fix lint issues

Signed-off-by: nitishfy <justnitish06@gmail.com>

---------

Signed-off-by: nitishfy <justnitish06@gmail.com>
(cherry picked from commit cfa1c89)
@pasha-codefresh pasha-codefresh requested a review from a team as a code owner November 8, 2024 11:01
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 35.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 55.04%. Comparing base (8340e1e) to head (449c53e).
Report is 18 commits behind head on release-2.13.

Files with missing lines Patch % Lines
cmd/main.go 28.57% 5 Missing ⚠️
util/app/path/path.go 0.00% 5 Missing ⚠️
cmd/util/app.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.13   #20718      +/-   ##
================================================
+ Coverage         54.98%   55.04%   +0.05%     
================================================
  Files               320      320              
  Lines             54514    54688     +174     
================================================
+ Hits              29976    30102     +126     
- Misses            21972    22002      +30     
- Partials           2566     2584      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh pasha-codefresh mentioned this pull request Nov 8, 2024
3 tasks
@pasha-codefresh pasha-codefresh merged commit d03ccf3 into argoproj:release-2.13 Nov 8, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants