chore: use testify instead of testing.Fatal or testing.Error in applicationset #20726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
mmorel-35
force-pushed
the
testifier/require-error
branch
from
0b72c84 to
001c137
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20726 +/- ##
=======================================
Coverage 55.17% 55.18%
=======================================
Files 324 324
Lines 55259 55259
=======================================
+ Hits 30487 30492 +5
+ Misses 22158 22156 -2
+ Partials 2614 2611 -3 ☔ View full report in Codecov by Sentry. |
mmorel-35
force-pushed
the
testifier/require-error
branch
from
c133c05 to
0637a10
Compare
mmorel-35
force-pushed
the
testifier/require-error
branch
3 times, most recently
from
6fc27fa to
2ea6de4
Compare
andrii-korotkov-verkada
approved these changes
Nov 9, 2024
…cationset Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
testifier/require-error
branch
from
2ea6de4 to
39b8a05
Compare
andrii-korotkov-verkada
approved these changes
Nov 9, 2024
crenshaw-dev
approved these changes
Nov 11, 2024
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
…cationset (argoproj#20726) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description