Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add health check for ClusterResourceSet #20746

Merged

Conversation

nueavv
Copy link
Member

@nueavv nueavv commented Nov 11, 2024

Add Health Check for ClusterResourceSet

  • Returns Degraded status if the ResourcesApplied condition is False
  • Returns Healthy status if the ResourcesApplied condition is True
  • Returns Progressing status if the condition is absent or still in progress

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@nueavv nueavv requested a review from a team as a code owner November 11, 2024 03:47
Copy link

bunnyshell bot commented Nov 11, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@nueavv nueavv changed the title add health check for ClusterResourceSet (feat) add health check for ClusterResourceSet Nov 11, 2024
@nueavv nueavv changed the title (feat) add health check for ClusterResourceSet feat: add health check for ClusterResourceSet Nov 11, 2024
@nueavv nueavv force-pushed the feat/ClusterResourceSet-healthcheck branch 4 times, most recently from 3be864d to 3fec174 Compare November 12, 2024 11:52
Signed-off-by: nueavv <nuguni@kakao.com>
@nueavv nueavv force-pushed the feat/ClusterResourceSet-healthcheck branch from 3fec174 to 36c0155 Compare November 12, 2024 12:35
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@40c6077). Learn more about missing BASE report.
Report is 386 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20746   +/-   ##
=========================================
  Coverage          ?   55.12%           
=========================================
  Files             ?      324           
  Lines             ?    55256           
  Branches          ?        0           
=========================================
  Hits              ?    30462           
  Misses            ?    22174           
  Partials          ?     2620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return hs
end

-- Resources Applied
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resourced not applied?

hs.status = "Degraded"
hs.message = condition.message
return hs
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What other conditions are possible? Should we consider them?

@crenshaw-dev crenshaw-dev merged commit fdf539d into argoproj:master Dec 15, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants