-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add health check for ClusterResourceSet #20746
feat: add health check for ClusterResourceSet #20746
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
3be864d
to
3fec174
Compare
Signed-off-by: nueavv <nuguni@kakao.com>
3fec174
to
36c0155
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20746 +/- ##
=========================================
Coverage ? 55.12%
=========================================
Files ? 324
Lines ? 55256
Branches ? 0
=========================================
Hits ? 30462
Misses ? 22174
Partials ? 2620 ☔ View full report in Codecov by Sentry. |
return hs | ||
end | ||
|
||
-- Resources Applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resourced not applied?
hs.status = "Degraded" | ||
hs.message = condition.message | ||
return hs | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What other conditions are possible? Should we consider them?
Add Health Check for ClusterResourceSet
Checklist: