feat: Adding skipSchemaValidation flag (#20771)

[dmosesson]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Closes #20771

Tentatively also closes:

• Add support for passing --skip-schema-validation to help #20771
• chore(deps): Update helm to v3.16.2 #20678
• feat: Upgrade helm to v3.16.2, dependency for #20287 #20650
• Add a SyncOption to enable / disable helm schema validation #20287

This allows argo to deploy helm charts that have JSON schema files for helm charts in locations that do not have internet access.

Some notes:

• I had some issues regenerating some of the files, and probably too many of those are included (I tried to run make codegen and had issues, and make codegen-local ran with some slightly different versions I suspect.
• The kustomize tests for me mostly failed, but I think that is more an artifact of the above, where I installed in somewhat incorrectly
• Helm had to be updated to 3.16.0 for this change, not sure if that should be a separate PR or not (and most probably I missed some of the places it should have been updated)

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[crenshaw-dev]

Besides one tweak, lgtm! Can you merge master and re-run codegen?

[crenshaw-dev]

Nice test! One tweak

[codecov]

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.00%. Comparing base (c6804e9) to head (5b9e20d).
Report is 432 commits behind head on master.

Files with missing lines	Patch %	Lines
util/helm/cmd.go	0.00%	2 Missing and 1 partial ⚠️
cmd/util/app.go	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20831      +/-   ##
==========================================
+ Coverage   54.97%   55.00%   +0.03%     
==========================================
  Files         324      324              
  Lines       55417    55427      +10     
==========================================
+ Hits        30464    30488      +24     
+ Misses      22334    22318      -16     
- Partials     2619     2621       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dmosesson]

@crenshaw-dev Are there any more changes you are looking for, or its good to go from your perspective? I think all the issues flagged above have been addressed

[ishitasequeira]

Overall PR looks good to me!! Just left a quick question for understanding the extra change.

@crenshaw-dev any more concerns about the PR?

[ishitasequeira]

QQ: Is the name field required here? I do not think this change is related to skipSchemaValidation flag changes.

[dmosesson]

It is. In helm 3.16, this property is now required (its not documented anywhere, but the test errors were saying it was a missing required attribute). Given that helm 3.16 is a requirement for this feature, it was added here

[rumstead]

LGTM

stale

[crenshaw-dev]

@ishitasequeira no concerns from me

[ishitasequeira]

Changes look good!! Thanks @dmosesson !!

[jdvorak8660]

This is a fantastic change, but appears to only apply to single source applications. Is there a plan to incorporate this feature when using multiple sources?

[crenshaw-dev]

@jdvorak8660 this should work fine for multi-source apps. The helm.skipSchemaValidation field is embedded in each item in the spec.sources field. They're the same struct.

[jdvorak8660]

@jdvorak8660 this should work fine for multi-source apps. The helm.skipSchemaValidation field is embedded in each item in the spec.sources field. They're the same struct.

Thanks for the response. I did not experience this when I attempted to use the option for multiple sources, but I'll go back and make sure I wasn't making some silly mistake. When it didn't work as expected I assumed it was not an option as it is also not referenced in the documentation for multiple sources.

Any chance you have an example of a working multi source application with this option I could reference?

Edit: @crenshaw-dev I may have found my issue. Can you confirm this change was only made in 2.14 (latest release candidate) and is not available in the latest stable release 2.13.3?