Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix get-previous-release test case #20863

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

leoluz
Copy link
Collaborator

@leoluz leoluz commented Nov 20, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz leoluz requested a review from a team as a code owner November 20, 2024 15:13
Copy link

bunnyshell bot commented Nov 20, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) November 20, 2024 15:19
@crenshaw-dev crenshaw-dev merged commit fc9b33b into argoproj:master Nov 20, 2024
26 checks passed
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@3da5a3d). Learn more about missing BASE report.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20863   +/-   ##
=========================================
  Coverage          ?   55.04%           
=========================================
  Files             ?      324           
  Lines             ?    55397           
  Branches          ?        0           
=========================================
  Hits              ?    30493           
  Misses            ?    22284           
  Partials          ?     2620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Nov 21, 2024
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants