-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show multisource details for an appset when using argocd appset get
command
#20903
fix: show multisource details for an appset when using argocd appset get
command
#20903
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good. Can you fix the failing tests?
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: nitishfy <justnitish06@gmail.com>
48f4100
to
8866c04
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20903 +/- ##
=======================================
Coverage 55.02% 55.02%
=======================================
Files 324 324
Lines 55417 55421 +4
=======================================
+ Hits 30493 30497 +4
- Misses 22308 22312 +4
+ Partials 2616 2612 -4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: nitishfy <justnitish06@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
… get` command (argoproj#20903) * fix: show multisource details for an appset Signed-off-by: nitishfy <justnitish06@gmail.com> * remove extra comment Signed-off-by: nitishfy <justnitish06@gmail.com> * fix failing tests Signed-off-by: nitishfy <justnitish06@gmail.com> * fix lint issues Signed-off-by: nitishfy <justnitish06@gmail.com> --------- Signed-off-by: nitishfy <justnitish06@gmail.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Closes #20902
Checklist:
Before:
After: