Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show multisource details for an appset when using argocd appset get command #20903

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

nitishfy
Copy link
Member

Closes #20902
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Before:

> argocd appset get color-applicationset-multi-source
Name:               argocd/color-applicationset-multi-source
Project:            default
Server:             https://kubernetes.default.svc
Namespace:          {{namespace}}
Sources:
- Repo:             https://github.com/argoproj/argocd-example-apps.git
  Target:           HEAD
  Path:             apps
SyncPolicy:         <none>

CONDITION            STATUS  MESSAGE                                                 LAST TRANSITION
ErrorOccurred        False   Successfully generated parameters for all Applications  2024-11-21 18:54:36 +0530 IST
ParametersGenerated  True    Successfully generated parameters for all Applications  2024-11-21 18:47:40 +0530 IST
ResourcesUpToDate    True    ApplicationSet up to date                               2024-11-21 18:54:36 +0530 IST

After:

> argocd appset get color-applicationset-multi-source
Name:               argocd/color-applicationset-multi-source
Project:            default
Server:             https://kubernetes.default.svc
Namespace:          {{namespace}}
Sources:
- Repo:             https://github.com/argoproj/argocd-example-apps.git
  Target:           HEAD
  Path:             apps
- Repo:             https://github.com/argoproj/argocd-example-apps.git
  Target:           HEAD
  Path:             guestbook
SyncPolicy:         <none>

CONDITION            STATUS  MESSAGE                                                 LAST TRANSITION
ErrorOccurred        False   Successfully generated parameters for all Applications  2024-11-21 18:54:36 +0530 IST
ParametersGenerated  True    Successfully generated parameters for all Applications  2024-11-21 18:47:40 +0530 IST
ResourcesUpToDate    True    ApplicationSet up to date                               2024-11-21 18:54:36 +0530 IST

@nitishfy nitishfy requested a review from a team as a code owner November 21, 2024 18:21
Copy link

bunnyshell bot commented Nov 21, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good. Can you fix the failing tests?

Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: nitishfy <justnitish06@gmail.com>
@nitishfy nitishfy force-pushed the nitish/appset-multi-source branch from 48f4100 to 8866c04 Compare November 22, 2024 08:06
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (9f1431e) to head (11a568a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20903   +/-   ##
=======================================
  Coverage   55.02%   55.02%           
=======================================
  Files         324      324           
  Lines       55417    55421    +4     
=======================================
+ Hits        30493    30497    +4     
- Misses      22308    22312    +4     
+ Partials     2616     2612    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: nitishfy <justnitish06@gmail.com>
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit 32cc663 into argoproj:master Nov 22, 2024
27 checks passed
@nitishfy nitishfy deleted the nitish/appset-multi-source branch November 22, 2024 11:31
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
… get` command (argoproj#20903)

* fix: show multisource details for an appset

Signed-off-by: nitishfy <justnitish06@gmail.com>

* remove extra comment

Signed-off-by: nitishfy <justnitish06@gmail.com>

* fix failing tests

Signed-off-by: nitishfy <justnitish06@gmail.com>

* fix lint issues

Signed-off-by: nitishfy <justnitish06@gmail.com>

---------

Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argocd appset get command doesn't show multiple sources details
2 participants