Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Graceful handling of panic in application set controller reconcile (#20935) #20940

Conversation

andrii-korotkov-verkada
Copy link
Contributor

@andrii-korotkov-verkada andrii-korotkov-verkada commented Nov 25, 2024

Closes #20935

Recover from panic if it happens, similar to how application controller does it.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

…cile (argoproj#20935)

Closes argoproj#20935

Recover from panic if it happens, similar to how application controller does it.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
@andrii-korotkov-verkada andrii-korotkov-verkada requested a review from a team as a code owner November 25, 2024 09:10
Copy link

bunnyshell bot commented Nov 25, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.02%. Comparing base (32cc663) to head (e6bf5b0).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...cationset/controllers/applicationset_controller.go 20.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20940      +/-   ##
==========================================
- Coverage   55.04%   55.02%   -0.03%     
==========================================
  Files         324      324              
  Lines       55421    55465      +44     
==========================================
+ Hits        30504    30517      +13     
- Misses      22303    22328      +25     
- Partials     2614     2620       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit 9009e57 into argoproj:master Nov 25, 2024
33 checks passed
@andrii-korotkov-verkada andrii-korotkov-verkada deleted the 20935-graceful-handling-of-panic-in-appset-controller-reconcile branch November 25, 2024 13:45
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
…cile (argoproj#20935) (argoproj#20940)

Closes argoproj#20935

Recover from panic if it happens, similar to how application controller does it.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Typos in goTemplateOptions in ApplicationSet CR can lead to applicationset controller panic
2 participants