Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update golang test image to use 1.23.4 multiarch #21174

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

todaywasawesome
Copy link
Contributor

Seems to be an issue with the current sha but this one is working.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Seems to be an issue with the current sha but this one is working. 

Signed-off-by: Dan Garfield <dan@codefresh.io>
@todaywasawesome todaywasawesome requested a review from a team as a code owner December 13, 2024 19:25
Copy link

bunnyshell bot commented Dec 13, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@todaywasawesome todaywasawesome changed the title Update golang test image to use 1.23.4 multiarch chore(deps) Update golang test image to use 1.23.4 multiarch Dec 13, 2024
@todaywasawesome todaywasawesome changed the title chore(deps) Update golang test image to use 1.23.4 multiarch chore(deps): Update golang test image to use 1.23.4 multiarch Dec 13, 2024
@todaywasawesome todaywasawesome enabled auto-merge (squash) December 13, 2024 19:28
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.84%. Comparing base (72c711e) to head (37a4eae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21174      +/-   ##
==========================================
+ Coverage   53.42%   53.84%   +0.42%     
==========================================
  Files         324      324              
  Lines       55587    55587              
==========================================
+ Hits        29696    29933     +237     
+ Misses      23287    23059     -228     
+ Partials     2604     2595       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

> crane digest docker.io/library/golang:1.23.4
sha256:70031844b8c225351d0bb63e2c383f80db85d92ba894e3da7e13bcf80efa9a37

@todaywasawesome todaywasawesome merged commit 8dbddb1 into master Dec 13, 2024
30 of 32 checks passed
@todaywasawesome todaywasawesome deleted the golang-multi-arch branch December 13, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants