Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused defaults from image workflow #21183

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

crenshaw-dev
Copy link
Member

Ran an action linter on a whim and realized these two inputs specify defaults even though they're required inputs. So the defaults never actually get used.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev marked this pull request as ready for review December 15, 2024 20:43
@crenshaw-dev crenshaw-dev requested review from a team as code owners December 15, 2024 20:43
Copy link

bunnyshell bot commented Dec 15, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@030a7be). Learn more about missing BASE report.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #21183   +/-   ##
=========================================
  Coverage          ?   53.81%           
=========================================
  Files             ?      324           
  Lines             ?    55649           
  Branches          ?        0           
=========================================
  Hits              ?    29949           
  Misses            ?    23100           
  Partials          ?     2600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishitasequeira ishitasequeira merged commit e878ad5 into argoproj:master Dec 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants