Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new fake k8s client constructor #21186

Merged

Conversation

crenshaw-dev
Copy link
Member

fake.NewSimpleClientset is deprecated in favor of fake.NewClientset.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Copy link

bunnyshell bot commented Dec 16, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@030a7be). Learn more about missing BASE report.
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/admin/cluster.go 0.00% 1 Missing ⚠️
cmd/argocd/commands/admin/repo.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #21186   +/-   ##
=========================================
  Coverage          ?   55.23%           
=========================================
  Files             ?      324           
  Lines             ?    55649           
  Branches          ?        0           
=========================================
  Hits              ?    30738           
  Misses            ?    22276           
  Partials          ?     2635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev marked this pull request as ready for review December 16, 2024 01:59
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner December 16, 2024 01:59
@ishitasequeira ishitasequeira merged commit 5cdb1a0 into argoproj:master Dec 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants