Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Graceful shutdown for API Server (redo) (#18642) #21224

Merged
merged 3 commits into from
Dec 17, 2024

Re-run tests

c85f3d6
Select commit
Loading
Failed to load commit list.
Merged

chore: Graceful shutdown for API Server (redo) (#18642) #21224

Re-run tests
c85f3d6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 17, 2024 in 0s

55.17% (+0.14%) compared to 46bfc10

View this Pull Request on Codecov

55.17% (+0.14%) compared to 46bfc10

Details

Codecov Report

Attention: Patch coverage is 71.07438% with 35 lines in your changes missing coverage. Please review.

Project coverage is 55.17%. Comparing base (46bfc10) to head (c85f3d6).

Files with missing lines Patch % Lines
server/server.go 79.80% 17 Missing and 4 partials ⚠️
cmd/argocd-server/commands/argocd_server.go 0.00% 8 Missing ⚠️
util/cache/redis.go 20.00% 3 Missing and 1 partial ⚠️
util/session/state.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21224      +/-   ##
==========================================
+ Coverage   55.03%   55.17%   +0.14%     
==========================================
  Files         338      338              
  Lines       57075    57167      +92     
==========================================
+ Hits        31410    31543     +133     
+ Misses      22968    22923      -45     
- Partials     2697     2701       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov