Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve the failing e2e appset tests for ksonnet applications #21580

Merged

Conversation

reggie-k
Copy link
Member

@reggie-k reggie-k commented Jan 20, 2025

ksonnet apps were deleted from the argocd-examples-repo:
argoproj/argocd-example-apps@ce918f9

So now ksonnet-related e2e tests are failing.
Removed ksonnet apps from the e2e tests.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Jan 20, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@reggie-k reggie-k changed the title fix: rollback the fix(appset): events not honouring configured namespaces fix: resolve the failing e2e appset tests for ksonnet applications Jan 20, 2025
…examples repo

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k reggie-k force-pushed the resolve-ksonnet-guestbook-failing-test branch from 81f8975 to 2702141 Compare January 20, 2025 19:03
@reggie-k reggie-k marked this pull request as ready for review January 20, 2025 19:34
@reggie-k reggie-k requested a review from a team as a code owner January 20, 2025 19:34
@ishitasequeira ishitasequeira enabled auto-merge (squash) January 21, 2025 02:25
@ishitasequeira ishitasequeira merged commit 6f38327 into argoproj:master Jan 21, 2025
26 checks passed
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.33%. Comparing base (606bd5b) to head (d1fa787).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21580   +/-   ##
=======================================
  Coverage   55.33%   55.33%           
=======================================
  Files         339      339           
  Lines       57172    57172           
=======================================
  Hits        31636    31636           
  Misses      22818    22818           
  Partials     2718     2718           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.14

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.13

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.12

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 21, 2025
…21580)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.11

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 21, 2025
…21580)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 21, 2025
…21580)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
crenshaw-dev pushed a commit that referenced this pull request Jan 21, 2025
…herry-pick #21580) (#21604)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Co-authored-by: Regina Voloshin <regina.voloshin@codefresh.io>
crenshaw-dev pushed a commit that referenced this pull request Jan 21, 2025
…herry-pick #21580) (#21605)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Co-authored-by: Regina Voloshin <regina.voloshin@codefresh.io>
crenshaw-dev pushed a commit that referenced this pull request Jan 21, 2025
…herry-pick #21580) (#21606)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Co-authored-by: Regina Voloshin <regina.voloshin@codefresh.io>
crenshaw-dev pushed a commit that referenced this pull request Jan 21, 2025
…herry-pick #21580) (#21607)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Co-authored-by: Regina Voloshin <regina.voloshin@codefresh.io>
dudo pushed a commit to dudo/argo-cd that referenced this pull request Jan 25, 2025
…rgoproj#21580)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Brett C. Dudo <brett@dudo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants