-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve the failing e2e appset tests for ksonnet applications #21580
Merged
ishitasequeira
merged 3 commits into
argoproj:master
from
reggie-k:resolve-ksonnet-guestbook-failing-test
Jan 21, 2025
Merged
fix: resolve the failing e2e appset tests for ksonnet applications #21580
ishitasequeira
merged 3 commits into
argoproj:master
from
reggie-k:resolve-ksonnet-guestbook-failing-test
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
reggie-k
changed the title
fix: rollback the fix(appset): events not honouring configured namespaces
fix: resolve the failing e2e appset tests for ksonnet applications
Jan 20, 2025
…examples repo Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
reggie-k
force-pushed
the
resolve-ksonnet-guestbook-failing-test
branch
from
January 20, 2025 19:03
81f8975
to
2702141
Compare
10 tasks
pasha-codefresh
approved these changes
Jan 20, 2025
ishitasequeira
approved these changes
Jan 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21580 +/- ##
=======================================
Coverage 55.33% 55.33%
=======================================
Files 339 339
Lines 57172 57172
=======================================
Hits 31636 31636
Misses 22818 22818
Partials 2718 2718 ☔ View full report in Codecov by Sentry. |
/cherry-pick release-2.14 |
/cherry-pick release-2.13 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
…21580) Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
/cherry-pick release-2.12 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
…21580) Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
/cherry-pick release-2.11 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
…21580) Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
…21580) Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
7 tasks
dudo
pushed a commit
to dudo/argo-cd
that referenced
this pull request
Jan 25, 2025
…rgoproj#21580) Signed-off-by: reggie-k <regina.voloshin@codefresh.io> Signed-off-by: Brett C. Dudo <brett@dudo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ksonnet apps were deleted from the argocd-examples-repo:
argoproj/argocd-example-apps@ce918f9
So now ksonnet-related e2e tests are failing.
Removed ksonnet apps from the e2e tests.
Checklist: