Fix Helm parameters with comma #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #2334 +/- ##
==========================================
+ Coverage 38.76% 38.78% +0.01%
==========================================
Files 109 109
Lines 14192 14196 +4
==========================================
+ Hits 5502 5506 +4
Misses 7971 7971
Partials 719 719
Continue to review full report at Codecov.
|
olivierlemasle
force-pushed
the
fixcomma
branch
from
8c54a9a to
0044121
Compare
This commit fixes Helm parsing of parameters values containing a comma. The issue was first found as argoproj#1660, and fixed in argoproj#1720. However, commit 4e9772e, in argoproj#1865 removed the call to `cleanHelmParameters`, hence the regression.
olivierlemasle
force-pushed
the
fixcomma
branch
from
0044121 to
f8b2a28
Compare
|
CI tests fail at step "Check nothing has changed"... I checked https://argoproj.github.io/argo-cd/developer-guide/ci/#check-nothing-has-changed-step-fails but it seems every change in the proposed patch is unrelated to changes in this PR. Is the problem on CI pipeline or in my PR ? Should I apply |
|
Yes please. |
|
@alexec Done; CI tests now succeed. |
alexec
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes Helm parsing of parameters values containing a comma.
The issue was first found as #1660, and fixed in #1720. However, commit 4e9772e, in #1865, removed the call to
cleanHelmParameters, hence the regression.