Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Helm v3 CRD are not deployed #3345

Merged
merged 9 commits into from
Apr 3, 2020
Merged

fix: Helm v3 CRD are not deployed #3345

merged 9 commits into from
Apr 3, 2020

Conversation

mayzhang2000
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

@mayzhang2000 mayzhang2000 changed the title 3336 helm3 crd fix: Helm v3 CRD are not deployed Apr 3, 2020
@codecov
Copy link

codecov bot commented Apr 3, 2020 •
edited
Loading

Codecov Report

Merging #3345 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3345   +/-   ##
=======================================
  Coverage   39.87%   39.88%           
=======================================
  Files         175      175           
  Lines       19019    19020    +1     
  Branches      272      272           
=======================================
+ Hits         7584     7586    +2     
+ Misses      10499    10498    -1     
  Partials      936      936
Impacted Files Coverage Δ
util/helm/helmver.go 76.92% <ø> (ø)
util/helm/cmd.go 42.27% <100.00%> (+0.95%) ⬆️
pkg/apis/application/v1alpha1/hack.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fdf573...61f72de. Read the comment docs.

jannfis
jannfis requested changes Apr 3, 2020
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just minor comments about a typo

util/helm/cmd.go Outdated Show resolved Hide resolved
util/helm/helmver.go Outdated Show resolved Hide resolved
util/helm/helmver.go Outdated Show resolved Hide resolved
@jannfis
Copy link
Member

jannfis commented Apr 3, 2020

Thanks @mayzhang2000 - I just got one additional comment:

Maybe it would make sense in the corresponding E2E test to check that the CRD has actually been synced correctly, using maybe ResourceSyncStatusIs() expectation.

jannfis
jannfis approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, mayzhang2000! LGTM now!

alexmt
alexmt approved these changes Apr 3, 2020
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review @jannfis !

@mayzhang2000 mayzhang2000 merged commit 55bc144 into argoproj:master Apr 3, 2020
@mayzhang2000
Copy link
Contributor Author

closes #3336

alexmt pushed a commit that referenced this pull request Apr 6, 2020
@mayzhang2000 @alexmt
fix: Helm v3 CRD are not deployed (#3345)
76241f9 
* Fixing could not find plugin issue when app sync and app diff

* Fixing codegen error

* Revert "Fixing codegen error"

This reverts commit b2dcfb8

* Fixing codegen error

* If user is logged in, settings API would return ConfigManagementPlugins

* For helm3, add flag --include-crds when calling helm template to support helm3 crd

* Fixing typo.

* Added further assertion of ResourceSyncStatusIs for CRD resources.
MarkusBauerBE added a commit to MarkusBauerBE/argocd-vault-plugin that referenced this pull request Mar 3, 2022
@MarkusBauerBE
Update plugin usage for helm
4a61734 
Update helm plugin usage to include install-crds bringing it inline with default ArgoCD helm behaviour (ArgoCD defaults to setting install-crds) 
See: argoproj/argo-cd#3345
@MarkusBauerBE MarkusBauerBE mentioned this pull request Mar 3, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayzhang2000 @jannfis @alexmt