fix: use glob matcher in casbin built-in model #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
added
cherry-pick/1.5
jannfis
approved these changes
Jul 20, 2020
| @@ -128,6 +128,7 @@ p, mike, *, *, foo/obj, deny | |||
| p, trudy, applications, get, foo/obj, allow | |||
| p, trudy, applications/*, get, foo/obj, allow | |||
| p, trudy, applications/secrets, get, foo/obj, deny | |||
| p, danny, applications, get, */obj, allow | |||
There was a problem hiding this comment.
I think it would be good to add some more wildcard patterns to test against, somewhere in the middle etc. Just to make sure :)
There was a problem hiding this comment.
added one more case with * in the middle with two checks.
jessesuen
approved these changes
Jul 20, 2020
alexmt
force-pushed
the
3963-rbac-policy-glob
branch
from
f9fbbd0 to
2e2a67c
Compare
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Jul 29, 2020
rachelwang20
pushed a commit
to rachelwang20/argo-cd
that referenced
this pull request
Aug 5, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3963
PR updates built-in casbin model to use
globMatchinstead ofkeyMatchthat implements proper glob matching.