Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update gitops engine version (issue #1816) #4552

Merged
merged 5 commits into from
Oct 14, 2020

Conversation

wtam2018
Copy link
Contributor

@wtam2018 wtam2018 commented Oct 14, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

Fixes: #1816

@wtam2018 wtam2018 changed the title refactor: update gitops engine version #1816 refactor: update gitops engine version (issue #1816) Oct 14, 2020
@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #4552 into master will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4552      +/-   ##
==========================================
- Coverage   41.44%   41.34%   -0.11%     
==========================================
  Files         123      123              
  Lines       16809    16809              
==========================================
- Hits         6967     6949      -18     
- Misses       8837     8860      +23     
+ Partials     1005     1000       -5     
Impacted Files Coverage Δ
controller/appcontroller.go 49.77% <0.00%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f512d21...653547c. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 3ae1d13 into argoproj:master Oct 14, 2020
dixneuf19 pushed a commit to dixneuf19/argo-cd that referenced this pull request Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diff on Endpoint confused by IP sorting
3 participants