Add documentation for helm, application sources, and parameter overrides #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
approved these changes
Jul 26, 2018
docs/getting_started.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # ArgoCD Getting Started | |||
|
|
|||
| An example Ksonnet guestbook application is provided to demonstrates how ArgoCD works. | |||
| An example guestbook application is provided to demonstrates how ArgoCD works. | |||
There was a problem hiding this comment.
nitpicking: demonstrates -> demonstrate
docs/parameters.md
Outdated
| (e.g. `argocd app set guestbook -p guestbook=image=example/guestbook:abcd123`). A sync operation | ||
| would result in the application being redeployed with the new image. | ||
|
|
||
| 2. An repository of helm manifests is already public available (e.g. https://github.com/helm/charts). |
There was a problem hiding this comment.
An repository -> A repository
docs/parameters.md
Outdated
| (e.g. `argocd app set guestbook -p guestbook=image=example/guestbook:abcd123`). A sync operation | ||
| would result in the application being redeployed with the new image. | ||
|
|
||
| 2. An repository of helm manifests is already public available (e.g. https://github.com/helm/charts). |
There was a problem hiding this comment.
public available -> publicly available
docs/tracking_strategies.md
Outdated
|
|
||
| ssetSince commit SHAs cannot change meaning, the only way to change the live state of an application |
|
Thanks for reviewing so carefully. Will make the changes. |
|
Holding off on merging docs until release is cut. |
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Sep 29, 2023
Signed-off-by: ls0f <lovedboy.tk@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs can be read here:
https://github.com/jessesuen/argo-cd/tree/helm-docs/docs