Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): Add endpoint for node information #4746

Merged
merged 3 commits into from
Nov 4, 2020
Merged

feat(server): Add endpoint for node information #4746

merged 3 commits into from
Nov 4, 2020

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Nov 3, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

@rbreeze rbreeze requested review from alexmt and jessesuen November 3, 2020 20:21
alexmt
alexmt requested changes Nov 3, 2020
View reviewed changes
server/application/application.proto Outdated
@@ -28,6 +28,11 @@ message ApplicationQuery {
optional string selector = 5 [(gogoproto.nullable) = false];
}

message NodeQuery {
// get nodes associated with this application
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// get nodes associated with this application
// the application's name

server/application/application.go Show resolved Hide resolved
server/application/application.go Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
@rbreeze rbreeze merged commit e2d5d48 into argoproj:pod-view Nov 4, 2020
rbreeze added a commit that referenced this pull request Nov 10, 2020
@rbreeze
feat(server): Add endpoint for node information (#4746)
3763483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt requested changes

@jessesuen jessesuen Awaiting requested review from jessesuen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbreeze @alexmt