Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Pod view #5091

Merged
merged 6 commits into from
Jan 5, 2021
Merged

feat(ui): Pod view #5091

merged 6 commits into from
Jan 5, 2021

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Dec 18, 2020 •
edited
Loading

Screen Shot 2020-12-21 at 1 47 57 PM

Screen Shot 2020-12-21 at 1 47 50 PM

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

@rbreeze
feat(server): Pod view server (#5089)
e1075bf 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze
feat(server): Pod view metrics (#5090)
1d672e7 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze
feat(ui): Pod view UI (#5092)
c7301b4 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze
Run codegen and fix application test
f8834d8 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze
Fix info test and lint
1a446ab 
Signed-off-by: Remington Breeze <remington@breeze.software>
@codecov-io
Copy link

codecov-io commented Dec 21, 2020 •
edited
Loading

Codecov Report

Merging #5091 (73e5b02) into master (45b3e48) will decrease coverage by 0.30%.
The diff coverage is 30.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5091      +/-   ##
==========================================
- Coverage   40.82%   40.51%   -0.31%     
==========================================
  Files         133      135       +2     
  Lines       18154    18374     +220     
==========================================
+ Hits         7411     7444      +33     
- Misses       9672     9854     +182     
- Partials     1071     1076       +5
Impacted Files Coverage Δ
server/application/application.go 28.07% <2.70%> (-1.00%) ⬇️
server/server.go 55.12% <88.88%> (+0.59%) ⬆️
controller/cache/info.go 63.91% <100.00%> (+1.35%) ⬆️
cmd/argocd/commands/cluster.go 2.68% <0.00%> (-8.81%) ⬇️
util/git/client.go 49.20% <0.00%> (-0.80%) ⬇️
util/argo/argo.go 58.89% <0.00%> (-0.78%) ⬇️
cmd/util/app.go 33.75% <0.00%> (-0.34%) ⬇️
reposerver/repository/repository.go 62.39% <0.00%> (-0.18%) ⬇️
cmd/argocd-util/commands/argocd_util.go 4.19% <0.00%> (-0.01%) ⬇️
cmd/util/common.go 0.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b3e48...73e5b02. Read the comment docs.

@rbreeze rbreeze requested a review from alexmt December 21, 2020 19:57
alexmt
alexmt requested changes Dec 22, 2020
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99% compete! Noticed few minor issues

ui/src/app/applications/components/application-resource-tree/application-resource-tree.tsx Outdated Show resolved Hide resolved
ui/src/app/applications/components/application-pod-view/pod-view.tsx Show resolved Hide resolved
ui/src/app/applications/components/application-pod-view/pod-view.tsx Outdated Show resolved Hide resolved
ui/src/app/applications/components/utils.tsx Show resolved Hide resolved
@rbreeze
Fix react keys warnings and other bug fixes
73e5b02 
Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from alexmt January 5, 2021 17:45
alexmt
alexmt approved these changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@alexmt alexmt merged commit 5d6b321 into master Jan 5, 2021
@rbreeze rbreeze deleted the pod-view branch January 5, 2021 20:38
rbreeze added a commit that referenced this pull request Jan 12, 2021
@rbreeze
feat(ui): Pod view (#5091)
205c369 
* feat(server): Pod view server (#5089)

Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@alexmt alexmt mentioned this pull request Mar 16, 2021
Merged
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
@rbreeze @Shubhama19
feat(ui): Pod view (argoproj#5091)
0d56048 
* feat(server): Pod view server (argoproj#5089)

Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbreeze @codecov-io @alexmt