-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enable helm OCI to work for lots of different URLs without having to create a repo for each one #6027
fix: Enable helm OCI to work for lots of different URLs without having to create a repo for each one #6027
Conversation
Signed-off-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
Signed-off-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
Signed-off-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
…g to create a repo for each one Signed-off-by: May Zhang <may_zhang@intuit.com>
…mplate � Conflicts: � manifests/ha/namespace-install.yaml � manifests/namespace-install.yaml
…g to create a repo for each one Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #6027 +/- ##
==========================================
- Coverage 40.97% 40.94% -0.04%
==========================================
Files 147 147
Lines 19691 19725 +34
==========================================
+ Hits 8069 8076 +7
- Misses 10518 10538 +20
- Partials 1104 1111 +7
Continue to review full report at Codecov.
|
� Conflicts: � reposerver/repository/repository.go
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
� Conflicts: � manifests/ha/install.yaml � manifests/ha/namespace-install.yaml
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Good day fellows! Is it also expected to work with chart dependencies from OCI repositories? |
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
fixes: #5920
This PR is based on #6003.
Instead of creating a repo for each dependent helm oci URL, user can
argocd repocreds add localhost:5000/myrepo --enable-oci --type helm