Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable helm OCI to work for lots of different URLs without having to create a repo for each one #6027

Merged
merged 24 commits into from
Apr 19, 2021

Conversation

mayzhang2000
Copy link
Contributor

@mayzhang2000 mayzhang2000 commented Apr 14, 2021

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

fixes: #5920

This PR is based on #6003.

Instead of creating a repo for each dependent helm oci URL, user can
argocd repocreds add localhost:5000/myrepo --enable-oci --type helm

Shubhama19 and others added 10 commits April 12, 2021 13:43
Signed-off-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
Signed-off-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
Signed-off-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
…g to create a repo for each one

Signed-off-by: May Zhang <may_zhang@intuit.com>
…mplate

� Conflicts:
�	manifests/ha/namespace-install.yaml
�	manifests/namespace-install.yaml
…g to create a repo for each one

Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #6027 (0b34f90) into master (70d7f2b) will decrease coverage by 0.03%.
The diff coverage is 21.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6027      +/-   ##
==========================================
- Coverage   40.97%   40.94%   -0.04%     
==========================================
  Files         147      147              
  Lines       19691    19725      +34     
==========================================
+ Hits         8069     8076       +7     
- Misses      10518    10538      +20     
- Partials     1104     1111       +7     
Impacted Files Coverage Δ
cmd/argocd/commands/repocreds.go 0.00% <0.00%> (ø)
pkg/apis/application/v1alpha1/types.go 57.44% <ø> (ø)
server/application/application.go 30.72% <0.00%> (+0.03%) ⬆️
util/db/db.go 84.61% <ø> (ø)
util/settings/settings.go 41.46% <ø> (ø)
reposerver/repository/repository.go 60.71% <7.14%> (-0.95%) ⬇️
util/db/repository.go 62.50% <23.07%> (-1.67%) ⬇️
controller/state.go 68.95% <50.00%> (-0.20%) ⬇️
util/argo/argo.go 61.84% <60.00%> (-0.16%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d7f2b...0b34f90. Read the comment docs.

� Conflicts:
�	reposerver/repository/repository.go
@mayzhang2000 mayzhang2000 marked this pull request as draft April 14, 2021 18:02
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
@mayzhang2000 mayzhang2000 marked this pull request as ready for review April 15, 2021 15:07
Signed-off-by: May Zhang <may_zhang@intuit.com>
reposerver/repository/repository.proto Outdated Show resolved Hide resolved
util/settings/settings.go Show resolved Hide resolved
util/db/db.go Outdated Show resolved Hide resolved
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
� Conflicts:
�	manifests/ha/install.yaml
�	manifests/ha/namespace-install.yaml
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayzhang2000 mayzhang2000 merged commit 9c5ed91 into argoproj:master Apr 19, 2021
@jannfis jannfis mentioned this pull request Apr 20, 2021
3 tasks
@mballoni
Copy link

Good day fellows!

Is it also expected to work with chart dependencies from OCI repositories?

@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
@mayzhang2000 mayzhang2000 removed the needs-verification PR requires pre-release verification label Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable helm OCI to work for lots of different URLs without having to create a repo for each one
5 participants