Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update account.proto annotaion for gen grpc gateway #6684

Merged
merged 7 commits into from
Mar 26, 2022
Merged

fix: Update account.proto annotaion for gen grpc gateway #6684

merged 7 commits into from
Mar 26, 2022

Conversation

wei840222
Copy link
Contributor

For /api/v1/account/can-i/{resource}/{action}/{subresource}
the subresource in path parm may have slash, so it need be a wildcard
ex: /api/v1/account/can-i/{resource}/{action}/{subresource}
may be /api/v1/account/can-i/projects/create/abc/abc-123
for now it will return 404

@wei840222 wei840222 changed the title Update account.proto annotaion for gen grpc gateway fix: update account.proto annotaion for gen grpc gateway Jul 9, 2021
@wei840222 wei840222 closed this Jul 9, 2021
@wei840222 wei840222 reopened this Jul 9, 2021
@wei840222 wei840222 changed the title fix: update account.proto annotaion for gen grpc gateway fix: Update account.proto annotaion for gen grpc gateway Jul 9, 2021
Signed-off-by: wei840222 <wei840222@gmail.com>
@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #6684 (4d90355) into master (b1ff9db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6684   +/-   ##
=======================================
  Coverage   43.10%   43.10%           
=======================================
  Files         186      186           
  Lines       23359    23359           
=======================================
  Hits        10069    10069           
  Misses      11849    11849           
  Partials     1441     1441           
Impacted Files Coverage Δ
util/settings/settings.go 48.10% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ff9db...4d90355. Read the comment docs.

@wei840222
Copy link
Contributor Author

do I need to run make openapigen before commit?

@jannfis
Copy link
Member

jannfis commented Jul 13, 2021

You should run make codegen and check for any changes on your local checkout, commit them and push back.

@jannfis
Copy link
Member

jannfis commented Jul 13, 2021

Signed-off-by: wei840222 <wei840222@gmail.com>
@wei840222
Copy link
Contributor Author

@jannfis the ci seems stuck, can u have a look? thx a lot.

@ishitasequeira
Copy link
Member

Thanks @wei840222 for the PR. Can you try to retrigger the checks using this doc:https://argoproj.github.io/argo-cd/developer-guide/ci/#can-i-retrigger-the-checks-without-pushing-a-new-commit ?

Signed-off-by: wei.wan <wei.wan@linecorp.com>
@wei840222
Copy link
Contributor Author

re triggered

Signed-off-by: wei.wan <wei.wan@linecorp.com>
@pasha-codefresh
Copy link
Member

hey @wei840222 could you please retrigger the checks?

wei840222 and others added 3 commits March 25, 2022 20:51
Signed-off-by: wei <wei840222@gmail.com>
Signed-off-by: wei.wan <wei.wan@linecorp.com>
@wei840222
Copy link
Contributor Author

@pasha-codefresh
Done thx

@pasha-codefresh
Copy link
Member

Thank you!

@pasha-codefresh pasha-codefresh merged commit 0ac0112 into argoproj:master Mar 26, 2022
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
* fix: Update account.proto annotaion for gen grpc gateway

Signed-off-by: wei840222 <wei840222@gmail.com>

* fix: Changes from codegen

Signed-off-by: wei840222 <wei840222@gmail.com>

* Retrigger CI pipeline

Signed-off-by: wei.wan <wei.wan@linecorp.com>

* Retrigger CI pipeline

Signed-off-by: wei.wan <wei.wan@linecorp.com>

* fix: Changes from codegen

Signed-off-by: wei <wei840222@gmail.com>

* Retrigger CI pipeline

Signed-off-by: wei.wan <wei.wan@linecorp.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants