-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update account.proto annotaion for gen grpc gateway #6684
Conversation
Signed-off-by: wei840222 <wei840222@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6684 +/- ##
=======================================
Coverage 43.10% 43.10%
=======================================
Files 186 186
Lines 23359 23359
=======================================
Hits 10069 10069
Misses 11849 11849
Partials 1441 1441
Continue to review full report at Codecov.
|
do I need to run |
You should run |
For more information, refer to https://argo-cd.readthedocs.io/en/stable/developer-guide/contributing/#generate-api-glue-code-and-other-assets |
Signed-off-by: wei840222 <wei840222@gmail.com>
@jannfis the ci seems stuck, can u have a look? thx a lot. |
Thanks @wei840222 for the PR. Can you try to retrigger the checks using this doc:https://argoproj.github.io/argo-cd/developer-guide/ci/#can-i-retrigger-the-checks-without-pushing-a-new-commit ? |
Signed-off-by: wei.wan <wei.wan@linecorp.com>
re triggered |
Signed-off-by: wei.wan <wei.wan@linecorp.com>
hey @wei840222 could you please retrigger the checks? |
Signed-off-by: wei <wei840222@gmail.com>
Signed-off-by: wei.wan <wei.wan@linecorp.com>
@pasha-codefresh |
Thank you! |
* fix: Update account.proto annotaion for gen grpc gateway Signed-off-by: wei840222 <wei840222@gmail.com> * fix: Changes from codegen Signed-off-by: wei840222 <wei840222@gmail.com> * Retrigger CI pipeline Signed-off-by: wei.wan <wei.wan@linecorp.com> * Retrigger CI pipeline Signed-off-by: wei.wan <wei.wan@linecorp.com> * fix: Changes from codegen Signed-off-by: wei <wei840222@gmail.com> * Retrigger CI pipeline Signed-off-by: wei.wan <wei.wan@linecorp.com> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
For /api/v1/account/can-i/{resource}/{action}/{subresource}
the subresource in path parm may have slash, so it need be a wildcard
ex: /api/v1/account/can-i/{resource}/{action}/{subresource}
may be /api/v1/account/can-i/projects/create/abc/abc-123
for now it will return 404