Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7144 fix: add custom volume as Helm working dir #7162

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

irizzant
Copy link
Contributor

@irizzant irizzant commented Sep 4, 2021

Closes [#7144]
Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [] Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: irizzant <i.rizzante@gmail.com>
@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #7162 (a713aca) into master (9559613) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7162      +/-   ##
==========================================
- Coverage   41.14%   41.06%   -0.09%     
==========================================
  Files         158      158              
  Lines       21230    21274      +44     
==========================================
  Hits         8736     8736              
- Misses      11241    11285      +44     
  Partials     1253     1253              
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 0.54% <0.00%> (-0.02%) ⬇️
util/settings/settings.go 47.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9559613...a713aca. Read the comment docs.

@rwong2888
Copy link
Contributor

rwong2888 commented Sep 7, 2021

@irizzant I think it would make sense to include HELM_PLUGINS to the env

edit: nvm, plugins did not move from HELM_PLUGINS=/home/argocd/.local/share/helm/plugins/

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @irizzant ! Can you please add HELM_PLUGINS as suggested in #7144 (comment) ?

Run make manifests to update autogenerated install.yaml files.

@alexmt alexmt added the cherry-pick/2.1 Candidate for cherry picking into the 2.1 release branch label Sep 7, 2021
@irizzant
Copy link
Contributor Author

irizzant commented Sep 8, 2021

@alexmt see #7144 (comment) I also updated the manifests

Signed-off-by: Ivan Rizzante <ivan.rizzante@tech.sdb.it>
@irizzant irizzant requested a review from alexmt September 9, 2021 08:23
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you for research and the fix

@alexmt alexmt merged commit e0c07b8 into argoproj:master Sep 9, 2021
alexmt pushed a commit that referenced this pull request Sep 10, 2021
Signed-off-by: irizzant <i.rizzante@gmail.com>
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
argoproj#7144 fix: add custom volume as Helm working dir (argoproj#7162)

Signed-off-by: irizzant <i.rizzante@gmail.com>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
@irizzant irizzant deleted the pr-7144 branch December 21, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.1 Candidate for cherry picking into the 2.1 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants