-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#7144 fix: add custom volume as Helm working dir #7162
Conversation
Signed-off-by: irizzant <i.rizzante@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7162 +/- ##
==========================================
- Coverage 41.14% 41.06% -0.09%
==========================================
Files 158 158
Lines 21230 21274 +44
==========================================
Hits 8736 8736
- Misses 11241 11285 +44
Partials 1253 1253
Continue to review full report at Codecov.
|
@irizzant I think it would make sense to include edit: nvm, plugins did not move from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @irizzant ! Can you please add HELM_PLUGINS
as suggested in #7144 (comment) ?
Run make manifests
to update autogenerated install.yaml files.
@alexmt see #7144 (comment) I also updated the manifests |
Signed-off-by: Ivan Rizzante <ivan.rizzante@tech.sdb.it>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thank you for research and the fix
Signed-off-by: irizzant <i.rizzante@gmail.com>
argoproj#7144 fix: add custom volume as Helm working dir (argoproj#7162) Signed-off-by: irizzant <i.rizzante@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Closes [#7144]
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: