fix: check for issuing condition on Certificate #7217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Back <jonah@jonahback.com>
Codecov Report
@@ Coverage Diff @@
## master #7217 +/- ##
=======================================
Coverage 41.91% 41.91%
=======================================
Files 177 177
Lines 22994 22994
=======================================
Hits 9639 9639
Misses 11972 11972
Partials 1383 1383 Continue to review full report at Codecov.
|
|
Thank you! |
alexmt
approved these changes
Sep 29, 2021
|
The CI is failing due to a broken unit test that is not related to PR. The test is fixed in master already. @backjo can you please merge master changes to pull fix into your fork? |
alexmt
added a commit
that referenced
this pull request
Feb 25, 2022
Signed-off-by: Jonah Back <jonah@jonahback.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initially creating a
cert-manager.io/Certificateobject, it shows a degraded status in ArgoCD. To fix this, this PR adds a check for the 'Issuing' condition set to 'true', which means that the certificate is currently being issued and should be treated as 'Progressing', not 'Degraded'Signed-off-by: Jonah Back jonah@jonahback.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: