Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve sync window for cluster name also, not only server #7817

Merged

Conversation

pasha-codefresh
Copy link
Member

@pasha-codefresh pasha-codefresh commented Dec 1, 2021

Closes #7813

  • Add a unit test that covers this issue

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…' into fix-sync-window-for-cluster-name

# Conflicts:
#	pkg/apis/application/v1alpha1/types_test.go
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #7817 (e4e7255) into master (0f2f9a9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7817      +/-   ##
==========================================
+ Coverage   41.44%   41.46%   +0.01%     
==========================================
  Files         169      169              
  Lines       22239    22252      +13     
==========================================
+ Hits         9218     9226       +8     
- Misses      11703    11706       +3     
- Partials     1318     1320       +2     
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/types.go 55.19% <100.00%> (+0.20%) ⬆️
controller/cache/cache.go 9.42% <0.00%> (-1.09%) ⬇️
util/rbac/rbac.go 76.50% <0.00%> (-0.55%) ⬇️
util/settings/settings.go 47.24% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f2f9a9...e4e7255. Read the comment docs.

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync window cluster matching fails for apps using .spec.destination.name
2 participants