Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #790 - Fix application controller panic #791

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Nov 16, 2018

No description provided.

@alexmt alexmt requested a review from jessesuen November 16, 2018 17:55
@codecov-io
Copy link

codecov-io commented Nov 16, 2018

Codecov Report

Merging #791 into master will increase coverage by 0.02%.
The diff coverage is 62.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #791      +/-   ##
========================================
+ Coverage   26.97%    27%   +0.02%     
========================================
  Files          41     41              
  Lines        6353   6359       +6     
========================================
+ Hits         1714   1717       +3     
- Misses       4400   4401       +1     
- Partials      239    241       +2
Impacted Files Coverage Δ
util/diff/diff.go 60.52% <62.5%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 361931f...ea48330. Read the comment docs.

@alexmt alexmt requested a review from dthomson25 November 16, 2018 18:20
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add a test after publishing the patch?

@alexmt
Copy link
Collaborator Author

alexmt commented Nov 16, 2018

Thank you for review @dthomson25 . Added test to PR

@alexmt alexmt merged commit 3f7a0d3 into argoproj:master Nov 16, 2018
@alexmt alexmt deleted the 790-npe-fix branch November 16, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants