chore: use go install instead of deprecated go get #8333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Codecov Report
@@ Coverage Diff @@
## master #8333 +/- ##
==========================================
- Coverage 41.91% 41.91% -0.01%
==========================================
Files 177 178 +1
Lines 22994 23003 +9
==========================================
+ Hits 9639 9641 +2
- Misses 11972 11979 +7
Partials 1383 1383
Continue to review full report at Codecov.
|
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
alexmt
approved these changes
Feb 1, 2022
|
@crenshaw-dev Github won't let merging this PR until it is in a "draft". |
|
@alexmt yeah I was tryna run e2e tests locally before marking ready, but I guess it's fine to trust the CI checks. 😄 |
alexmt
pushed a commit
that referenced
this pull request
Feb 2, 2022
* chore: use go install instead of deprecated go get Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * docs: readme fixes Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
go getis deprecated for installing binaries.I've made these changes without 100% knowing the context in which these commands are run, so please review carefully. :-)