Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add --api-versions flag in helm diff cmd #8371

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

gdsoumya
Copy link
Member

@gdsoumya gdsoumya commented Feb 4, 2022

Signed-off-by: Soumya Ghosh Dastidar soumya@akuity.io

Fixes #3594
Linked to #7291

argocd app diff <app> --local . did not pass --app-versions to the helm diff command

Previous:

argo app diff filebeat --local ./charts/stable/filebeat/

INFO[0000] helm template . --name-template filebeat --namespace default --kube-version 1.21 --set monitoring.serviceMonitor.enabled=true --set monitoring.enabled=true --include-crds  dir=./charts/stable/filebeat/ execID=f08f8

After Change:

argo app diff filebeat --local ./charts/stable/filebeat/

INFO[0000] helm template . --name-template filebeat --namespace default --kube-version 1.21 --set monitoring.enabled=true --set monitoring.serviceMonitor.enabled=true --api-versions admissionregistration.k8s.io/v1 --api-versions admissionregistration.k8s.io/v1beta1 --api-versions apiextensions.k8s.io/v1 --api-versions apiextensions.k8s.io/v1beta1 --api-versions apiregistration.k8s.io/v1 --api-versions apiregistration.k8s.io/v1beta1 --api-versions apps/v1 --api-versions argoproj.io/v1alpha1 --api-versions autoscaling/v1 --api-versions autoscaling/v2beta1 --api-versions autoscaling/v2beta2 --api-versions batch/v1 --api-versions batch/v1beta1 --api-versions certificates.k8s.io/v1 --api-versions certificates.k8s.io/v1beta1 --api-versions coordination.k8s.io/v1 --api-versions coordination.k8s.io/v1beta1 --api-versions discovery.k8s.io/v1 --api-versions discovery.k8s.io/v1beta1 --api-versions events.k8s.io/v1 --api-versions events.k8s.io/v1beta1 --api-versions extensions/v1beta1 --api-versions flowcontrol.apiserver.k8s.io/v1beta1 --api-versions networking.k8s.io/v1 --api-versions networking.k8s.io/v1beta1 --api-versions node.k8s.io/v1 --api-versions node.k8s.io/v1beta1 --api-versions policy/v1 --api-versions policy/v1beta1 --api-versions rbac.authorization.k8s.io/v1 --api-versions rbac.authorization.k8s.io/v1beta1 --api-versions scheduling.k8s.io/v1 --api-versions scheduling.k8s.io/v1beta1 --api-versions storage.k8s.io/v1 --api-versions storage.k8s.io/v1beta1 --api-versions v1 --include-crds  dir=./charts/stable/filebeat/ execID=e4cc4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Soumya Ghosh Dastidar <soumya@akuity.io>
@gdsoumya gdsoumya changed the title fix: add --api-versions flag in helm diff cmd (#3594) fix: add --api-versions flag in helm diff cmd Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #8371 (128c25c) into master (1c7cddb) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8371      +/-   ##
==========================================
- Coverage   41.97%   41.97%   -0.01%     
==========================================
  Files         178      178              
  Lines       22894    22895       +1     
==========================================
  Hits         9610     9610              
- Misses      11905    11906       +1     
  Partials     1379     1379              
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 0.53% <0.00%> (-0.01%) ⬇️
util/settings/settings.go 47.08% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c7cddb...128c25c. Read the comment docs.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jessesuen jessesuen merged commit af270ad into argoproj:master Feb 5, 2022
alexmt pushed a commit that referenced this pull request Feb 25, 2022
Signed-off-by: Soumya Ghosh Dastidar <soumya@akuity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI doesn't seem to pass --api-versions option to Helm template command
2 participants