fix: Increase y-margin in resource tree view (#7183) #8597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8597 +/- ##
==========================================
+ Coverage 42.57% 42.59% +0.01%
==========================================
Files 177 184 +7
Lines 22988 23169 +181
==========================================
+ Hits 9787 9868 +81
- Misses 11804 11898 +94
- Partials 1397 1403 +6
Continue to review full report at Codecov.
|
rbreeze
approved these changes
Feb 23, 2022
|
/retest |
Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong
force-pushed
the
7183-IncreaseYMarginInResourceTree
branch
from
4d35f7b to
dd3797b
Compare
wojtekidd
pushed a commit
to wojtekidd/argo-cd
that referenced
this pull request
Apr 25, 2022
…j#8597) Signed-off-by: Keith Chong <kykchong@redhat.com> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keith Chong kykchong@redhat.com
This is a follow up issue to the zoom support added via #8290
When the tree structure consists of one long horizontal branch, the floating bar is in the way. In a lot of cases, the floating toolbar is fine to float above the tree contents, because the tree is scrollable. But in this case, the tree structure is not scrollable vertically, so the toolbar is in the way. We should increase the Y-margin.
Problem
With Fix:
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: