Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump helm version to 3.8.1 #8804

Merged
merged 2 commits into from
Apr 8, 2022
Merged

chore: bump helm version to 3.8.1 #8804

merged 2 commits into from
Apr 8, 2022

Conversation

Exodus
Copy link
Contributor

@Exodus Exodus commented Mar 17, 2022 •
edited
Loading

Signed-off-by: Miguel A. Alvarado V alvaradoma@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited
Loading

Codecov Report

Merging #8804 (5398736) into master (0ff1ada) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8804      +/-   ##
==========================================
- Coverage   44.96%   44.92%   -0.05%     
==========================================
  Files         212      212              
  Lines       25261    25262       +1     
==========================================
- Hits        11359    11349      -10     
- Misses      12295    12309      +14     
+ Partials     1607     1604       -3
Impacted Files Coverage Δ
reposerver/repository/repository.go 60.12% <100.00%> (+0.04%) ⬆️
applicationset/services/scm_provider/github.go 63.52% <0.00%> (-17.65%) ⬇️
applicationset/services/scm_provider/utils.go 88.50% <0.00%> (+4.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff1ada...5398736. Read the comment docs.

terrytangyuan
terrytangyuan reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the failing test TestHelmWithMultipleDependencies?

@Exodus Exodus force-pushed the feat/helm_bump_3.8.1 branch from 9505bac to 1b4ba1c Compare March 17, 2022 22:30
@chetan-rns
Copy link
Member

Error: repository name (https://localhost:9444/argo-e2e/testdata.git/helm-repo/local) contains '/', please specify a different name without '/'"" execID=8dbc2

@Exodus I think the e2e test is failing because Helm v3.8.1 doesn't allow repo names with / helm/helm#10462. Please see #8771 (comment)

@Exodus
Copy link
Contributor Author

Exodus commented Mar 30, 2022

Error: repository name (https://localhost:9444/argo-e2e/testdata.git/helm-repo/local) contains '/', please specify a different name without '/'"" execID=8dbc2

@Exodus I think the e2e test is failing because Helm v3.8.1 doesn't allow repo names with / helm/helm#10462. Please see #8771 (comment)

Thanks for input, I'll update the test and remove the /

@Exodus
chore: bump helm version to 3.8.1
07d477f 
Signed-off-by: Miguel A. Alvarado V <alvaradoma@gmail.com>
@Exodus Exodus force-pushed the feat/helm_bump_3.8.1 branch from 1b4ba1c to 07d477f Compare March 30, 2022 19:37
@Exodus
fix: Adding simple sanitize for repo name
5398736 
Signed-off-by: Miguel A. Alvarado V <alvaradoma@gmail.com>
chetan-rns
chetan-rns approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chetan-rns chetan-rns mentioned this pull request Apr 4, 2022
Open
crenshaw-dev
crenshaw-dev approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crenshaw-dev crenshaw-dev merged commit 2cdfafe into argoproj:master Apr 8, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Apr 9, 2022
@Exodus
chore: bump helm version to 3.8.1 (argoproj#8804)
2de0be3 
* chore: bump helm version to 3.8.1

Signed-off-by: Miguel A. Alvarado V <alvaradoma@gmail.com>

* fix: Adding simple sanitize for repo name

Signed-off-by: Miguel A. Alvarado V <alvaradoma@gmail.com>
Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
@Exodus @wojtekidd
chore: bump helm version to 3.8.1 (argoproj#8804)
6ce4f59 
* chore: bump helm version to 3.8.1

Signed-off-by: Miguel A. Alvarado V <alvaradoma@gmail.com>

* fix: Adding simple sanitize for repo name

Signed-off-by: Miguel A. Alvarado V <alvaradoma@gmail.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@chetan-rns chetan-rns chetan-rns approved these changes

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Exodus @chetan-rns @crenshaw-dev @terrytangyuan