feat: show sync wave in ui

[ciiay]

Signed off: yicai@redhat.com
Closes: #8598

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

Screenshot(updated):

[codecov]

Codecov Report

Merging #8902 (038fd98) into master (5f0e58d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8902      +/-   ##
==========================================
- Coverage   45.80%   45.79%   -0.01%     
==========================================
  Files         219      219              
  Lines       25864    25864              
==========================================
- Hits        11846    11845       -1     
- Misses      12372    12373       +1     
  Partials     1646     1646              

Impacted Files	Coverage Δ
applicationset/services/scm_provider/github.go	75.29% <0.00%> (-5.89%)	⬇️
util/settings/settings.go	48.10% <0.00%> (+0.46%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0e58d...038fd98. Read the comment docs.

[ciiay]

Hi @rbreeze , could you take a look at this PR? Thanks!

[rbreeze]

Looks good, just one small request

[pasha-codefresh]

@ciiay

First of all great job , i think in terms of ux the fact that column can contain or not contain sync order column is not good, you can see in screenshot same app table but different pages
I would suggest check if app contains sync waves show column otherwise no

[ciiay]

@ciiay

First of all great job , i think in terms of ux the fact that column can contain or not contain sync order column is not good, you can see in screenshot same app table but different pages I would suggest check if app contains sync waves show column otherwise no

Hi @pasha-codefresh , thanks for the detailed feedback. I learned a lot from it. Regarding this observation, previously I got a feedback that it looked weird when there was a Sync Order column while no values show up underneath it. So I added the check to each page of resources. I'm not sure about the best solution to this specific situation. Anymore thoughts about this?

Reference: ui/src/app/applications/components/application-details/application-resource-list.tsx line 20 - line 31

[keithchong]

Regarding the inconsistency in showing or not showing the column from page to page, I agree with @pasha-codefresh. If we always show it, then perhaps instead of having the column value blank, maybe show a dash/hyphen '-' ?

On the other hand, if we don't show the column if none of the resources have the sync waves/order, what will happen if a sync order is added to one of the resources, while you are on one of the pages? If you refresh, then the column will be added? Is that expected?

[ciiay]

Regarding the inconsistency in showing or not showing the column from page to page, I agree with @pasha-codefresh. If we always show it, then perhaps instead of having the column value blank, maybe show a dash/hyphen '-' ?

On the other hand, if we don't show the column if none of the resources have the sync waves/order, what will happen if a sync order is added to one of the resources, while you are on one of the pages? If you refresh, then the column will be added? Is that expected?

@keithchong Thanks for the suggestion. I agree it's better to keep it consistent, even when none of the resources has Sync Order information, we should keep the column just to make it consistent everywhere and every time the user opens the list view. I updated the code with displaying hyphen on empty Sync Order value. @pasha-codefresh How do you think about this solution?

How it looks when None resources has Sync Order value:

How it looks when some of the resources have Sync Order value:

[keithchong]

LGTM too, and Yi addressed the outstanding review comments.

[pasha-codefresh]

Great job

[rbreeze]

LGTM!