-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added github and gitlab token into env #8933
Conversation
Signed-off-by: rishabh625 <rishabhmishra625@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8933 +/- ##
==========================================
+ Coverage 43.40% 44.92% +1.51%
==========================================
Files 186 212 +26
Lines 23373 25261 +1888
==========================================
+ Hits 10145 11348 +1203
- Misses 11779 12309 +530
- Partials 1449 1604 +155
Continue to review full report at Codecov.
|
.github/workflows/ci-build.yaml
Outdated
@@ -71,6 +71,9 @@ jobs: | |||
runs-on: ubuntu-latest | |||
needs: | |||
- build-go | |||
env: | |||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GITHUB_TOKEN is a reserved secret name in Github. Please use E2E_TEST_GITHUB_TOKEN and E2E_TEST_GITLAB_TOKEN instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thnx! done! , i hope u meant for secrets name and not env variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexmt : please re review! eagerly waiting to see this fix, post merge test runs
Signed-off-by: rishabh625 <rishabhmishra625@gmail.com>
Signed-off-by: rishabh625 <rishabhmishra625@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The generators that depend on secrets can't be tested on a PR, maybe we should follow up on that.
* fix: Added github and gitlab token into env Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> * changed secret name as E2E Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> * Retrigger CI pipeline Signed-off-by: rishabh625 <rishabhmishra625@gmail.com> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Signed-off-by: rishabh625 rishabhmishra625@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Copied tokens into env variable needed by some of tests of application set
Related #8864