feat: Add cli support for additional linux based architectures, s390x + ppc64le

[davidkarlsen]

While AIX isn't a very popular platform these days, it would be valuable for some legacy platforms to be able to integrate with argo-cd via the CLI in order to die in a nice way :)

Signed-off-by: David J. M. Karlsen david@davidkarlsen.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Merging #8991 (0944e26) into master (a2b7798) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8991      +/-   ##
==========================================
- Coverage   46.06%   46.04%   -0.02%     
==========================================
  Files         217      217              
  Lines       25912    25912              
==========================================
- Hits        11936    11931       -5     
- Misses      12319    12323       +4     
- Partials     1657     1658       +1     

Impacted Files	Coverage Δ
applicationset/services/scm_provider/github.go	75.29% <0.00%> (-5.89%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b7798...0944e26. Read the comment docs.

[krishvoor]

Thanks for the changes, lgtm!

[krishvoor]

Minor nitpick:
Looks like Semantic Pull Request is throwing a red-flag

Can you update your PR Title - something similar to this like
chore: Add cli support for additional architectures and aix

[davidkarlsen]

@krishvoor fixed

[krishvoor]

Hi @rishabh625 - can you review it?

[rishabh625]

LGTM!

[davidkarlsen]

Hmm, CI does not actually build that steps it seems.
It fails when I:

make BIN_NAME=argocd-aix-ppc64 GOOS=aix GOARCH=ppc64 argocd-all
find /Users/et2448/projects/ext/github.com/argo-cd -name debug.test | xargs rm -f
CGO_ENABLED=0 GOOS=aix GOARCH=ppc64 go build -v -ldflags '-X github.com/argoproj/argo-cd/v2/common.version=2.4.0 -X github.com/argoproj/argo-cd/v2/common.buildDate=2022-04-05T20:47:18Z -X github.com/argoproj/argo-cd/v2/common.gitCommit=f8c4d217615efee278b9e32f1f5dd5e0d3b3d9ee -X github.com/argoproj/argo-cd/v2/common.gitTreeState=clean -X github.com/argoproj/argo-cd/v2/common.kubectlVersion=v0.23.1 -extldflags "-static"' -o /Users/et2448/projects/ext/github.com/argo-cd/dist/argocd-aix-ppc64 ./cmd
package github.com/argoproj/argo-cd/v2/cmd
        imports github.com/argoproj/argo-cd/v2/cmd/argocd-application-controller/commands
        imports github.com/argoproj/pkg/stats: build constraints exclude all Go files in /Users/et2448/go/pkg/mod/github.com/argoproj/pkg@v0.11.1-0.20211203175135-36c59d8fafe0/stats
make: *** [argocd-all] Error 1

locally

I guess not all packages can be cross-compiled

[krishvoor]

Right, CI might need QEMU Emulation to get it working..
Also, we have a patch for ppc64le/s390x for build-time/test dependencies here

[davidkarlsen]

Right, CI might need QEMU Emulation to get it working.. Also, we have a patch for ppc64le/s390x for build-time/test dependencies here

I guess it would be good to build all architectures in CI, so one does not get a surprise at release-time.

[34fathombelow]

Hmm, CI does not actually build that steps it seems. It fails when I:

make BIN_NAME=argocd-aix-ppc64 GOOS=aix GOARCH=ppc64 argocd-all
find /Users/et2448/projects/ext/github.com/argo-cd -name debug.test | xargs rm -f
CGO_ENABLED=0 GOOS=aix GOARCH=ppc64 go build -v -ldflags '-X github.com/argoproj/argo-cd/v2/common.version=2.4.0 -X github.com/argoproj/argo-cd/v2/common.buildDate=2022-04-05T20:47:18Z -X github.com/argoproj/argo-cd/v2/common.gitCommit=f8c4d217615efee278b9e32f1f5dd5e0d3b3d9ee -X github.com/argoproj/argo-cd/v2/common.gitTreeState=clean -X github.com/argoproj/argo-cd/v2/common.kubectlVersion=v0.23.1 -extldflags "-static"' -o /Users/et2448/projects/ext/github.com/argo-cd/dist/argocd-aix-ppc64 ./cmd
package github.com/argoproj/argo-cd/v2/cmd
        imports github.com/argoproj/argo-cd/v2/cmd/argocd-application-controller/commands
        imports github.com/argoproj/pkg/stats: build constraints exclude all Go files in /Users/et2448/go/pkg/mod/github.com/argoproj/pkg@v0.11.1-0.20211203175135-36c59d8fafe0/stats
make: *** [argocd-all] Error 1

locally

I guess not all packages can be cross-compiled

I also get the same error running this locally in Linux with QEMU. This would definitely cause a release to fail. @davidkarlsen Would you consider removing make BIN_NAME=argocd-aix-ppc64 GOOS=aix GOARCH=ppc64 argocd-all? The other additions would be really helpful since 2.4 will have support for ppc64le & s390x.

[davidkarlsen]

@34fathombelow fixed

[34fathombelow]

@davidkarlsen lgtm! If you don't mind changing the title of the PR to reflect only the architectures added.

[crenshaw-dev]

lgtm. @alexmt any objections?