Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: logs RBAC known UI issue section #9479

Merged
merged 3 commits into from
May 27, 2022
Merged

Conversation

reggie-k
Copy link
Member

@reggie-k reggie-k commented May 22, 2022

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

reggie-k added 3 commits May 14, 2022 21:20
…ith logs rbac

Signed-off-by: reggie-k <reginakagan@gmail.com>
…ith logs rbac

Signed-off-by: reggie-k <reginakagan@gmail.com>
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #9479 (f46f6fa) into master (ba7d2e7) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9479      +/-   ##
==========================================
- Coverage   45.71%   45.70%   -0.02%     
==========================================
  Files         221      221              
  Lines       26289    26289              
==========================================
- Hits        12019    12015       -4     
- Misses      12610    12613       +3     
- Partials     1660     1661       +1     
Impacted Files Coverage Δ
util/settings/settings.go 47.70% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7d2e7...f46f6fa. Read the comment docs.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crenshaw-dev crenshaw-dev merged commit 7e2af69 into argoproj:master May 27, 2022
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label May 31, 2022
crenshaw-dev pushed a commit that referenced this pull request May 31, 2022
* updated changelog and upgrade instructions to contain know UI issue with logs rbac

Signed-off-by: reggie-k <reginakagan@gmail.com>

* updated changelog and upgrade instructions to contain know UI issue with logs rbac

Signed-off-by: reggie-k <reginakagan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants