-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade kustomize to 4.5.5 #9650
Conversation
Signed-off-by: Hyeonmin Park <hyeonmin.park@kennysoft.kr>
Codecov Report
@@ Coverage Diff @@
## master #9650 +/- ##
=======================================
Coverage 45.76% 45.76%
=======================================
Files 225 225
Lines 26565 26565
=======================================
Hits 12157 12157
Misses 12751 12751
Partials 1657 1657
Continue to review full report at Codecov.
|
Don't know why integration tests in k3s v1.24.1 result to timeout. 🤔 |
It seems to have become flakey when 1.24.1 was introduced as a tested version. It's unrelated to your changes. |
@KENNYSOFT thanks for the PR! I'd recommend creating a 2.4-to-2.5 upgrade notes doc and add this upgrade. I don't think we'd want to cherry-pick the upgrade into 2.4. |
@KENNYSOFT updated the branch to fix the CI failure. Be sure to |
Signed-off-by: Hyeonmin Park <hyeonmin.park@kennysoft.kr>
a75fc13
to
290a423
Compare
Done, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Will wait for a second review to merge, since it's a significant change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I Agree that it shouldn't be cherry-picked in 2.4. I think it is good to merge this now to allow identifying 2.5 issues early.
Upgrade kustomize to 4.5.5, which introduced a lot of performance improvements: kubernetes-sigs/kustomize#4568.
Used script after download files from https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv4.5.5:
Also, unified checksum files ending to LF.
QUESTION: Do I need to explicitly write this to release notes even if it's bumping one minor version? #8227 (review) This comment says if two minor versions then should be, but I don't know for one.Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: