Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade kustomize to 4.5.5 #9650

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Conversation

KENNYSOFT
Copy link
Contributor

@KENNYSOFT KENNYSOFT commented Jun 14, 2022

Upgrade kustomize to 4.5.5, which introduced a lot of performance improvements: kubernetes-sigs/kustomize#4568.

Used script after download files from https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv4.5.5:

find kustomize*.gz | while read file
do
  sha256sum $file | sed 's/^  //' | sed 's/ \*/  /' | sed -E 's/v([0-9]+)/\1/' > $(echo $file | sed -E 's/v([0-9]+)/\1/').sha256
done

Also, unified checksum files ending to LF.

QUESTION: Do I need to explicitly write this to release notes even if it's bumping one minor version? #8227 (review) This comment says if two minor versions then should be, but I don't know for one.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Hyeonmin Park <hyeonmin.park@kennysoft.kr>
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #9650 (290a423) into master (a66046e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9650   +/-   ##
=======================================
  Coverage   45.76%   45.76%           
=======================================
  Files         225      225           
  Lines       26565    26565           
=======================================
  Hits        12157    12157           
  Misses      12751    12751           
  Partials     1657     1657           
Impacted Files Coverage Δ
util/settings/settings.go 48.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a66046e...290a423. Read the comment docs.

@KENNYSOFT
Copy link
Contributor Author

Don't know why integration tests in k3s v1.24.1 result to timeout. 🤔

@danielhelfand
Copy link
Contributor

Don't know why integration tests in k3s v1.24.1 result to timeout. 🤔

It seems to have become flakey when 1.24.1 was introduced as a tested version. It's unrelated to your changes.

@crenshaw-dev
Copy link
Member

@KENNYSOFT thanks for the PR! I'd recommend creating a 2.4-to-2.5 upgrade notes doc and add this upgrade.

I don't think we'd want to cherry-pick the upgrade into 2.4.

@crenshaw-dev
Copy link
Member

@KENNYSOFT updated the branch to fix the CI failure. Be sure to git pull before making any additional changes. :-)

Signed-off-by: Hyeonmin Park <hyeonmin.park@kennysoft.kr>
@KENNYSOFT
Copy link
Contributor Author

@KENNYSOFT thanks for the PR! I'd recommend creating a 2.4-to-2.5 upgrade notes doc and add this upgrade.

I don't think we'd want to cherry-pick the upgrade into 2.4.

Done, thanks!

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Will wait for a second review to merge, since it's a significant change.

@crenshaw-dev crenshaw-dev requested a review from leoluz June 17, 2022 14:31
@leoluz leoluz added this to the v2.5 milestone Jun 17, 2022
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I Agree that it shouldn't be cherry-picked in 2.4. I think it is good to merge this now to allow identifying 2.5 issues early.

@leoluz leoluz merged commit 6c4a6b7 into argoproj:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants