Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: webhook incorrectly misses cache on GenerateManifests (#9670) #9671

Merged
merged 1 commit into from
Jun 23, 2022
Merged

fix: webhook incorrectly misses cache on GenerateManifests (#9670) #9671

merged 1 commit into from
Jun 23, 2022

Conversation

nfillot
Copy link
Contributor

@nfillot nfillot commented Jun 15, 2022 •
edited
Loading

Fixes #9670

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

[ArgoCD] Fixing webhook typo in case of error in GetManifests
4cec93d 
Signed-off-by: Nicolas Fillot <nfillot@weborama.com>
@nfillot nfillot force-pushed the webhook-return-typo-error branch from 49da93a to 4cec93d Compare June 15, 2022 14:21
crenshaw-dev
crenshaw-dev requested changes Jun 15, 2022
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nfillot you've already put a lot of time into investigating this issue, but if it's reasonably easy, could you add a unit test to demonstrate what goes wrong without the change?

If it's not an easy test, I'm happy just to merge the typo fix. :-)

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #9671 (4cec93d) into master (56eb095) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #9671   +/-   ##
=======================================
  Coverage   45.85%   45.85%           
=======================================
  Files         226      226           
  Lines       26675    26675           
=======================================
  Hits        12231    12231           
  Misses      12783    12783           
  Partials     1661     1661
Impacted Files Coverage Δ
util/webhook/webhook.go 68.34% <0.00%> (ø)
util/settings/settings.go 48.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56eb095...4cec93d. Read the comment docs.

@crenshaw-dev crenshaw-dev changed the title fix: fix webhook typo in case of cache error in GetManifests fix: webhook incorrectly misses cache on GenerateManifests (#9670) Jun 23, 2022
crenshaw-dev
crenshaw-dev approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crenshaw-dev crenshaw-dev added cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch labels Jun 23, 2022
@crenshaw-dev crenshaw-dev merged commit a588e63 into argoproj:master Jun 23, 2022
crenshaw-dev pushed a commit that referenced this pull request Jun 23, 2022
@nfillot @crenshaw-dev
[ArgoCD] Fixing webhook typo in case of error in GetManifests (#9671)
4871daa 
Signed-off-by: Nicolas Fillot <nfillot@weborama.com>

Co-authored-by: Nicolas Fillot <nfillot@weborama.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
crenshaw-dev pushed a commit that referenced this pull request Jun 23, 2022
@nfillot @crenshaw-dev
[ArgoCD] Fixing webhook typo in case of error in GetManifests (#9671)
068ca89 
Signed-off-by: Nicolas Fillot <nfillot@weborama.com>

Co-authored-by: Nicolas Fillot <nfillot@weborama.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
crenshaw-dev pushed a commit that referenced this pull request Jun 23, 2022
@nfillot @crenshaw-dev
[ArgoCD] Fixing webhook typo in case of error in GetManifests (#9671)
e715e08 
Signed-off-by: Nicolas Fillot <nfillot@weborama.com>

Co-authored-by: Nicolas Fillot <nfillot@weborama.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
Copy link
Member

Cherry-picked onto 2.2 for release with 2.2.11, 2.3 for release with 2.3.6, and 2.4 for release with 2.4.3. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No warn logs when issue in cache with webhook
2 participants
@nfillot @crenshaw-dev