fix: Limit github hooks manager daemon lifetime to 10 min (#1930)

* fix: Start github hooks manager daemon only when DeleteHookOnFinish is enabled

Signed-off-by: Ivan Babiankou <ivan.babiankou@gmail.com>

eventsources/sources/github/start.go

@@ -365,17 +365,11 @@ func (el *EventListener) StartListening(ctx context.Context, dispatch func([]byt
 			// and old pod terminates, if DeleteHookOnFinish is true, the hook will be deleted from github.
 			// This is a workaround to mitigate the race conditions.
 			logger.Info("starting github hooks manager daemon")
-			ticker := time.NewTicker(60 * time.Second)
-			defer ticker.Stop()
-			for {
-				select {
-				case <-ctx.Done():
-					logger.Info("exiting github hooks manager daemon")
-					return
-				case <-ticker.C:
-					f()
-				}
+			for i := 0; i < 10; i++ {
+				time.Sleep(60 * time.Second)
+				f()
 			}
+			logger.Info("exiting github hooks manager daemon")
 		}()
 	} else {
 		logger.Info("no need to create webhooks")