fix(sensor-controller): Return err when a sensor spec is invalid. Fixes #1017 #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argoproj#1017 Signed-off-by: Derek Wang <whynowy@gmail.com>
alexec
approved these changes
Jan 19, 2021
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
argoproj#1017 (argoproj#1018) Signed-off-by: Derek Wang <whynowy@gmail.com>
|
Would it be possible to undo this change? Because after this change new deployments to Kubernetes with Argo events objects fail silently if you made a mistake in the spec. Before this change the deployment would end up in a Crashloopbackoff causing alerts to go off and ArgoCD to show visually something is wrong, this is not the case any longer. I ran into this problem today. I'd like to argue that generating a deployment when you made an error in the spec is safer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1017
Signed-off-by: Derek Wang whynowy@gmail.com
Checklist: