fix: Add logic to ticker loop to ensure subscription always exists with an open connection #861

terev · 2020-09-04T07:20:52Z

Summary

Fixes #860

This pr ensures that a subscription exists as long as there's an active connection to the eventbus.

Manual test plan

This was tested locally by installing argo-events and testing my dev sensor image.
I started an instance of the webhook eventbus/sensor. Then I verified that events flowed to the sensor.
I then deleted all of the nats eventbus pods to force close the connection kubectl delete po -n argo-events -l 'eventbus-name=default'
Then i verified that the subscription was eventually re-established and events flow correctly
I repeated the deletion steps to validate that it works multiple times

I couldn't find any tests that touch this area but i could've missed them?

… open connection

whynowy

This looks great! I tested by myself as well by randomly error out the subscription. Thanks for fixing it!

whynowy · 2020-09-04T17:44:18Z

sensors/listener.go

@@ -39,6 +40,15 @@ import (
 	sensortriggers "github.com/argoproj/argo-events/sensors/triggers"
 )

+func subscribeOnce(subLock *uint32, subscribe func()) {
+	// acquire subLock if not already held
+	if !atomic.CompareAndSwapUint32(subLock, 0, 1) {


Learnt something, thanks!

…th an open connection (#861)

…th an open connection (argoproj#861)

Add logic to ticker loop to ensure subscription always exists with an…

c912f04

… open connection

terev changed the title ~~Add logic to ticker loop to ensure subscription always exists with an open connection~~ fix: Add logic to ticker loop to ensure subscription always exists with an open connection Sep 4, 2020

whynowy approved these changes Sep 4, 2020

View reviewed changes

whynowy merged commit f2411be into argoproj:master Sep 4, 2020

whynowy pushed a commit that referenced this pull request Sep 4, 2020

fix: Add logic to ticker loop to ensure subscription always exists wi…

8961e46

…th an open connection (#861)

juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022

fix: Add logic to ticker loop to ensure subscription always exists wi…

eff6622

…th an open connection (argoproj#861)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add logic to ticker loop to ensure subscription always exists with an open connection #861

fix: Add logic to ticker loop to ensure subscription always exists with an open connection #861

terev commented Sep 4, 2020 •

edited

Loading

whynowy left a comment

whynowy Sep 4, 2020

fix: Add logic to ticker loop to ensure subscription always exists with an open connection #861

fix: Add logic to ticker loop to ensure subscription always exists with an open connection #861

Conversation

terev commented Sep 4, 2020 • edited Loading

Summary

Manual test plan

whynowy left a comment

Choose a reason for hiding this comment

whynowy Sep 4, 2020

Choose a reason for hiding this comment

terev commented Sep 4, 2020 •

edited

Loading