Skip to content

Commit

Permalink
feat(argo-rollouts): Add rollout plugin gloo platform rbac (#2404)
Browse files Browse the repository at this point in the history
* feat(argo-rollouts): Add rollout plugin gloo platform rbac

Signed-off-by: Brian Gottfried <bgottfried91@gmail.com>

* feat(argo-rollouts): Add rollout plugin gloo platform rbac information to README

Signed-off-by: Brian Gottfried <bgottfried91@gmail.com>

---------

Signed-off-by: Brian Gottfried <bgottfried91@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
  • Loading branch information
bgottfried91 and yu-croco authored Jan 7, 2024
1 parent d1389a9 commit 9892e50
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 3 deletions.
6 changes: 3 additions & 3 deletions charts/argo-rollouts/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: v1.6.4
description: A Helm chart for Argo Rollouts
name: argo-rollouts
version: 2.34.0
version: 2.34.1
home: https://github.com/argoproj/argo-helm
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
keywords:
Expand All @@ -18,5 +18,5 @@ annotations:
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: changed
description: Allow setting log config for rollouts dashboard
- kind: added
description: Added Gloo Platform provider RBAC rules
1 change: 1 addition & 0 deletions charts/argo-rollouts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ For full list of changes please check ArtifactHub [changelog].
| providerRBAC.providers.awsAppMesh | bool | `true` | Adds RBAC rules for the AWS App Mesh provider |
| providerRBAC.providers.awsLoadBalancerController | bool | `true` | Adds RBAC rules for the AWS Load Balancer Controller provider |
| providerRBAC.providers.contour | bool | `true` | Adds RBAC rules for the Contour provider, see `https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-contour/blob/main/README.md` |
| providerRBAC.providers.glooPlatform | bool | `true` | Adds RBAC rules for the Gloo Platform provider, see `https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-glooplatform/blob/main/README.md` |
| providerRBAC.providers.istio | bool | `true` | Adds RBAC rules for the Istio provider |
| providerRBAC.providers.smi | bool | `true` | Adds RBAC rules for the SMI provider |
| providerRBAC.providers.traefik | bool | `true` | Adds RBAC rules for the Traefik provider |
Expand Down
9 changes: 9 additions & 0 deletions charts/argo-rollouts/templates/controller/clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -267,5 +267,14 @@ rules:
- watch
- update
{{- end }}
{{- if .Values.providerRBAC.providers.glooPlatform }}
# Access needed when using the Gloo Platform provider
- apiGroups:
- networking.gloo.solo.io
resources:
- routetables
verbs:
- '*'
{{- end }}
{{- end }}
{{- end }}
9 changes: 9 additions & 0 deletions charts/argo-rollouts/templates/controller/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -256,5 +256,14 @@ rules:
- get
- update
{{- end }}
{{- if .Values.providerRBAC.providers.glooPlatform }}
# Access needed when using the Gloo Platform provider
- apiGroups:
- networking.gloo.solo.io
resources:
- routetables
verbs:
- '*'
{{- end }}
{{- end }}
{{- end }}
2 changes: 2 additions & 0 deletions charts/argo-rollouts/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,8 @@ providerRBAC:
apisix: true
# -- Adds RBAC rules for the Contour provider, see `https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-contour/blob/main/README.md`
contour: true
# -- Adds RBAC rules for the Gloo Platform provider, see `https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-glooplatform/blob/main/README.md`
glooPlatform: true

dashboard:
# -- Deploy dashboard server
Expand Down

0 comments on commit 9892e50

Please sign in to comment.